Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible

From	Caesar Wang <caesar.upstream@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible
Date	2015-09-18 10:30 +0200
Message-ID	<q9Zdo-5zu-13@gated-at.bofh.it> (permalink)
References	(2 earlier) <q9Dwd-7Az-9@gated-at.bofh.it> <q9DFV-7M8-19@gated-at.bofh.it> <q9EiC-kL-13@gated-at.bofh.it> <q9Esh-wC-3@gated-at.bofh.it> <q9YKn-4Mg-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Daniel,

在 2015年09月18日 15:55, Daniel Lezcano 写道:
> On 09/17/2015 12:19 PM, Caesar Wang wrote:
>>
>>
>> 在 2015年09月17日 18:06, Daniel Lezcano 写道:
>>> On 09/17/2015 11:28 AM, Caesar Wang wrote:
>>>> Hi Daniel,
>>>>
>>>>
>>>> 在 2015年09月17日 17:11, Daniel Lezcano 写道:
>>>>>
>>>>> Hi Caesar,
>>>>>
>>>>>
>>>>> On 09/17/2015 09:51 AM, Caesar Wang wrote:
>>>>>> Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform,
>>>>>> There are some failure with build up on timer driver for rockchip.
>>>>>>
>>>>>> logs:
>>>>>> ...
>>>>>> drivers/clocksource/rockchip_timer.c:156:13: error: 'NO_IRQ'
>>>>>> undeclared
>>>>>
>>>>> I think the NO_IRQ definition is missing for ARM64.
>>>>
>>>> Yep, Maybe better to compatible if we don't use the 'NO_IRQ',
>>>
>>> Hmm, after digging into drivers/of/irq.c and kernel/irq/irqdomain.c
>>>
>>> when there is an error it returns zero. So NO_IRQ and -1 are not
>>> correct and on the other side zero can be a valid irq. That sounds a
>>> little bit fuzzy to me.
>>
>> I believe the 'NO_IRQ' is better select if 'NO_IRQ' is defined on ARM64
>> platform.
>>
>>      irq = irq_of_parse_and_map(np, 0);
>>
>>      if (irq  == NO_IRQ)
>> ...
>> Also, that's ok if we instead of the 'irq < 0'  or  '!irq' , right?
>
>
> Hi Caesar,
>
> so regarding Thomas and Russel answers, let's replace NO_IRQ by '!irq'.

Fixed, I will send the patch v1.

>
> Thanks.
>
>   -- Daniel
>
>

-- 
Thanks,
Caesar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible Caesar Wang <wxt@rock-chips.com> - 2015-09-17 10:00 +0200
  Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-09-17 11:20 +0200
    Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Caesar Wang <caesar.upstream@gmail.com> - 2015-09-17 11:30 +0200
      Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible Heiko Stübner <heiko@sntech.de> - 2015-09-17 11:50 +0200
      Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-09-17 12:10 +0200
        Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Caesar Wang <caesar.upstream@gmail.com> - 2015-09-17 12:20 +0200
          Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-09-18 10:00 +0200
            Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Caesar Wang <caesar.upstream@gmail.com> - 2015-09-18 10:30 +0200
            Re: [PATCH 1/3] clocksource: rockchip: Make the driver more  readability and compatible Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-18 11:10 +0200
        Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Thomas Gleixner <tglx@linutronix.de> - 2015-09-17 12:30 +0200
          Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-09-17 13:00 +0200
            Re: [PATCH 1/3] clocksource: rockchip: Make the driver more  readability and compatible Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-17 23:20 +0200
              Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-09-18 10:00 +0200

csiph-web