Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1226790

Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible

Show all headers | View raw

Hi Caesar,


On 09/17/2015 09:51 AM, Caesar Wang wrote:
> Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform,
> There are some failure with build up on timer driver for rockchip.
>
> logs:
> ...
> drivers/clocksource/rockchip_timer.c:156:13: error: 'NO_IRQ' undeclared

I think the NO_IRQ definition is missing for ARM64.

> /tmp/ccdAnNy5.s:47: Error: missing immediate expression at  operand 1 --
> `dsb`
> ...
>
> The problem was different semantics of dsb on btw arm32 and arm64,
> Here we can convert the dsb with insteading of dsb(sy).

What happens to ARM32 then ?

> Meanwhile, I change a bit to make the code more readability for driver
> when I check the code style.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible Caesar Wang <wxt@rock-chips.com> - 2015-09-17 10:00 +0200
  Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-09-17 11:20 +0200
    Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Caesar Wang <caesar.upstream@gmail.com> - 2015-09-17 11:30 +0200
      Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible Heiko Stübner <heiko@sntech.de> - 2015-09-17 11:50 +0200
      Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-09-17 12:10 +0200
        Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Caesar Wang <caesar.upstream@gmail.com> - 2015-09-17 12:20 +0200
          Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-09-18 10:00 +0200
            Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Caesar Wang <caesar.upstream@gmail.com> - 2015-09-18 10:30 +0200
            Re: [PATCH 1/3] clocksource: rockchip: Make the driver more  readability and compatible Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-18 11:10 +0200
        Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Thomas Gleixner <tglx@linutronix.de> - 2015-09-17 12:30 +0200
          Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-09-17 13:00 +0200
            Re: [PATCH 1/3] clocksource: rockchip: Make the driver more  readability and compatible Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-17 23:20 +0200
              Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability  and compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-09-18 10:00 +0200

csiph-web