Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code

From	"Wu, Songjun" <songjun.wu@atmel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code
Date	2015-09-14 08:40 +0200
Message-ID	<q8vAK-6Ed-9@gated-at.bofh.it> (permalink)
References	(6 earlier) <q6qc9-48n-15@gated-at.bofh.it> <q6E5s-7qJ-13@gated-at.bofh.it> <q6Kky-7VO-17@gated-at.bofh.it> <q6ZWi-59b-21@gated-at.bofh.it> <q7tUm-7o1-17@gated-at.bofh.it>
Organization	ATMEL

Show all headers | View raw


On 9/11/2015 18:34, Mark Brown wrote:
> On Thu, Sep 10, 2015 at 10:31:04AM +0800, Wu, Songjun wrote:
>> On 9/9/2015 17:52, Mark Brown wrote:
>
>>> Yes, that's what's going to end up happening but it's not how controls
>>> are expected to behave - applications will expect changing one control
>>> to leave others unaffected so it's better to return an error rather than
>>> change the other control.
>
>> If application change non EQ controls, the others will be unaffected. But
>> the classD IP can only supports one EQ control at once, these three EQ
>> controls point to the same register field, if application set a different EQ
>> control, the error occurs, there will be many errors, it's not very
>> reasonable to application. The best way I think is if application set one EQ
>> control, the other EQ controls will change to 0dB, it's also consistent with
>> fact.
>
> There's no really good solutions here - this is why my initial
> suggestion was to have a single enumerated control.
>
You are right, your suggestion is reasonable, to have a single 
enumerated control. The second version will be made and sent soon.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code Mark Brown <broonie@kernel.org> - 2015-09-07 18:30 +0200
  Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-08 11:40 +0200
    Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code Mark Brown <broonie@kernel.org> - 2015-09-08 14:30 +0200
      Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-09 05:20 +0200
        Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code Mark Brown <broonie@kernel.org> - 2015-09-09 12:00 +0200
          Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-10 04:40 +0200
            Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code Mark Brown <broonie@kernel.org> - 2015-09-11 12:40 +0200
              Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-14 08:40 +0200

csiph-web