Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code
Date	2015-09-09 12:00 +0200
Message-ID	<q6Kky-7VO-17@gated-at.bofh.it> (permalink)
References	(3 earlier) <q5EKf-3sJ-33@gated-at.bofh.it> <q67sS-2ob-17@gated-at.bofh.it> <q6nxE-ij-29@gated-at.bofh.it> <q6qc9-48n-15@gated-at.bofh.it> <q6E5s-7qJ-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Sep 09, 2015 at 11:16:08AM +0800, Wu, Songjun wrote:
> On 9/8/2015 20:23, Mark Brown wrote:

> >If you want to have three controls you need to write code so that the
> >user can only change one of them from 0dB at once, returning an error
> >otherwise.  That was why it looked like they were three separate
> >controls.

> If user operates two or tree controls at the same time, for my
> understanding, these operations are serial actually in kernel, not parallel,
> and the last operation will be effective. I only write the function
> 'classd_get_eq_enum' to get the enumeration value, if user changes one of
> controls, the other controls will get 0dB. Is my understanding correct?

Yes, that's what's going to end up happening but it's not how controls
are expected to behave - applications will expect changing one control
to leave others unaffected so it's better to return an error rather than
change the other control.

Thread

Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code Mark Brown <broonie@kernel.org> - 2015-09-07 18:30 +0200
  Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-08 11:40 +0200
    Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code Mark Brown <broonie@kernel.org> - 2015-09-08 14:30 +0200
      Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-09 05:20 +0200
        Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code Mark Brown <broonie@kernel.org> - 2015-09-09 12:00 +0200
          Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-10 04:40 +0200
            Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code Mark Brown <broonie@kernel.org> - 2015-09-11 12:40 +0200
              Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-14 08:40 +0200

csiph-web