Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1224475

Re: [PATCH v4 04/52] PCI: Optimize bus min_align/size calculation during sizing

From Yinghai Lu <yinghai@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v4 04/52] PCI: Optimize bus min_align/size calculation during sizing
Date 2015-09-14 23:40 +0200
Message-ID <q8JDI-1AN-19@gated-at.bofh.it> (permalink)
References <pZNZT-3SZ-3@gated-at.bofh.it> <pZO9A-44i-15@gated-at.bofh.it> <q8IxX-8vQ-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Sep 14, 2015 at 1:21 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> I spent a couple hours trying to understand the v3 version of this
> patch, and I gave you some detailed examples and questions.  If you
> want me to look at v4, I expect you to try to clarify the changelog to
> help answer those questions.

you example is  addressed in following patch that support alt_size

and this patch only handle min_align searching for size is not equal to
align.

>
> The goal is that someone with reasonable familiarity with Linux and
> PCI would be able to read the changelogs and understand what happened,
> without having to search out all the email discussions.

Agreed. But changelog for this should not talk alt_size support in
following patch.

Also please let me know if you prefer to reviewing v5 that would be
re-based on v4.3-rc1
instead of v4. or I could wait to post v5 after you finish v4.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v4 04/52] PCI: Optimize bus min_align/size calculation  during sizing Bjorn Helgaas <bhelgaas@google.com> - 2015-09-14 22:30 +0200
  Re: [PATCH v4 04/52] PCI: Optimize bus min_align/size calculation  during sizing Yinghai Lu <yinghai@kernel.org> - 2015-09-14 23:40 +0200
    Re: [PATCH v4 04/52] PCI: Optimize bus min_align/size calculation  during sizing Bjorn Helgaas <bhelgaas@google.com> - 2015-09-15 17:00 +0200
      Re: [PATCH v4 04/52] PCI: Optimize bus min_align/size calculation  during sizing Yinghai Lu <yinghai@kernel.org> - 2015-09-16 21:40 +0200

csiph-web