Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1225265

Re: [PATCH v4 04/52] PCI: Optimize bus min_align/size calculation during sizing

Show all headers | View raw

On Mon, Sep 14, 2015 at 4:37 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> On Mon, Sep 14, 2015 at 1:21 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>> I spent a couple hours trying to understand the v3 version of this
>> patch, and I gave you some detailed examples and questions.  If you
>> want me to look at v4, I expect you to try to clarify the changelog to
>> help answer those questions.
>
> you example is  addressed in following patch that support alt_size

My fundamental question about this changelog was "I want to understand
what makes 256M/768M 'optimal.'"  That needs to be addressed in the
changelog for *this* patch, and this changelog is essentially
unchanged from v3.

>> The goal is that someone with reasonable familiarity with Linux and
>> PCI would be able to read the changelogs and understand what happened,
>> without having to search out all the email discussions.
>
> Agreed. But changelog for this should not talk alt_size support in
> following patch.

Maybe you split the patches in a way that makes this changelog not
match this patch.  I don't know, and I don't really have time to
figure it all out myself.

> Also please let me know if you prefer to reviewing v5 that would be
> re-based on v4.3-rc1
> instead of v4. or I could wait to post v5 after you finish v4.

Any future series you post should be based on the most recent -rc1 at
the time.  I apply patches to branches based on -rc1 unless they
actually depend on something merged after -rc1.

We are not communicating effectively, so I'm going to dispose of some
of the other pending patches before returning to this series.  If
there are simple patches with good changelogs early in the series, I
can apply those incrementally.  But this patch is [04/52] and is a
sticking point, so that strategy doesn't get me very far.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 04/52] PCI: Optimize bus min_align/size calculation  during sizing Bjorn Helgaas <bhelgaas@google.com> - 2015-09-14 22:30 +0200
  Re: [PATCH v4 04/52] PCI: Optimize bus min_align/size calculation  during sizing Yinghai Lu <yinghai@kernel.org> - 2015-09-14 23:40 +0200
    Re: [PATCH v4 04/52] PCI: Optimize bus min_align/size calculation  during sizing Bjorn Helgaas <bhelgaas@google.com> - 2015-09-15 17:00 +0200
      Re: [PATCH v4 04/52] PCI: Optimize bus min_align/size calculation  during sizing Yinghai Lu <yinghai@kernel.org> - 2015-09-16 21:40 +0200

csiph-web