Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1224214

Re: [PATCH 2/4] ARM: sun8i: Add the A33 AHB1 gates clock driver

From Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/4] ARM: sun8i: Add the A33 AHB1 gates clock driver
Date 2015-09-14 16:50 +0200
Message-ID <q8DeX-Je-35@gated-at.bofh.it> (permalink)
References <q7wyS-2OJ-7@gated-at.bofh.it> <q7wyT-2OJ-21@gated-at.bofh.it> <q8heq-2Xi-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

Hi Peter,

On Sun, Sep 13, 2015 at 05:13:12PM +0200, Peter Korsgaard wrote:
> >>>>> "Maxime" == Maxime Ripard <maxime.ripard@free-electrons.com> writes:
> 
>  > The A33 has different a different gates array than the A23, add the node to
>  > the DT.
> 
> NIT: 2x different.

Ah, good catch, thanks!

> Shouldn't the a23 one then move from sun8i-a23-a33.dtsi to
> sun8i-a23.dtsi?

It is, but in order to preserve bisectability, I declared the A33 node
first, that has precedence over the A23 still in the common DTSI, and
removed the A23 in the next patch.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] ARM: sun8i: Fix A23 and A33 clock gates indices  Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-11 15:30 +0200
  [PATCH 1/4] clk: sunxi: Add A33 gates support Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-11 15:30 +0200
  [PATCH 2/4] ARM: sun8i: Add the A33 AHB1 gates clock driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-11 15:30 +0200
    Re: [PATCH 2/4] ARM: sun8i: Add the A33 AHB1 gates clock driver Peter Korsgaard <peter@korsgaard.com> - 2015-09-13 17:20 +0200
      Re: [PATCH 2/4] ARM: sun8i: Add the A33 AHB1 gates clock driver Peter Korsgaard <peter@korsgaard.com> - 2015-09-13 17:20 +0200
      Re: [PATCH 2/4] ARM: sun8i: Add the A33 AHB1 gates clock driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-14 16:50 +0200
  [PATCH 4/4] ARM: sun8i: A23: Add missing msgbox gate Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-11 15:30 +0200
  [PATCH 3/4] ARM: sun8i: Move A23 AHB1 gates out of common DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-11 15:30 +0200
  Re: [PATCH 0/4] ARM: sun8i: Fix A23 and A33 clock gates indices Chen-Yu Tsai <wens@csie.org> - 2015-09-16 07:50 +0200
  Re: [PATCH 0/4] ARM: sun8i: Fix A23 and A33 clock gates indices Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-18 22:10 +0200

csiph-web