Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1224213

Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors

Show all headers | View raw

On Mon, Sep 14, 2015 at 03:38:36PM +0100, Punit Agrawal wrote:
> Mark Rutland <mark.rutland@arm.com> writes:
> 
> >> >> +Sensor bindings for the sensors based on SCPI Message Protocol
> >> >> +--------------------------------------------------------------
> >> >> +SCPI provides an API to access the various sensors on the SoC.
> >> >> +
> >> >> +Required properties:
> >> >> +- compatible : should be "arm,scpi-sensors".
> >> >> +- #thermal-sensor-cells: should be set to 1. This property follows the
> >> >> +			 thermal device tree bindings[2].
> >> >
> >> > You need to specify what the valid values for this cell are.
> >> 
> >> The enumeration depends on the number of sensors exported by SCP
> >> firmware - which is platform dependent. I could add add something like
> >> if you think that is helpful -
> >> 
> >> "Valid cell value is a number between 0..n-1, where n is the number
> >> of sensors exported by SCP firmware."
> >
> > Can the FW identifer space have holes? Or are they always contiguous?
> 
> The way the SCP interface is defined, the sensor identifiers are
> contiguous, but not all are temperature sensors.

Ok. So how exactly are they enumerated for this binding?

> > If this is the same as the raw FW identifer value, specify that.
> > Otherwise, you need to specify the mapping.
> 
> I'll update the patch to add mappings for Juno r0 (and r1 if I can get
> my hands on one).

If there's identical logic mapping the two, we might just be able to
describe that rather than having to add tables all the time.

> > There needs to be enough information for a dts author to figure out
> > which values to place in the DT.
> 
> I understand. Except sometimes it is hard to get the firmware to commit to not
> modify the ordering - discoverability and all that. :)

If they do that, then things are broken regardless, no? I guess that'll
be clear if/when I see how the mapping works.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] SCPI Sensor support Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 15:10 +0200
  [PATCH v3 3/5] hwmon: Support sensors exported via ARM SCP interface Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 15:10 +0200
  [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 15:10 +0200
    Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI  sensors Mark Rutland <mark.rutland@arm.com> - 2015-09-14 15:20 +0200
      Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 15:40 +0200
        Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI  sensors Mark Rutland <mark.rutland@arm.com> - 2015-09-14 16:00 +0200
          Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 16:40 +0200
            Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI  sensors Mark Rutland <mark.rutland@arm.com> - 2015-09-14 16:50 +0200
              Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 17:10 +0200
                Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI  sensors Mark Rutland <mark.rutland@arm.com> - 2015-09-14 17:20 +0200
                Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 18:10 +0200
            Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI  sensors "Jon Medhurst (Tixy)" <tixy@linaro.org> - 2015-09-14 20:20 +0200
              Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-15 11:40 +0200
                Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI  sensors "Jon Medhurst (Tixy)" <tixy@linaro.org> - 2015-09-15 12:50 +0200
                Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI  sensors Mark Rutland <mark.rutland@arm.com> - 2015-09-15 13:10 +0200
                Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI  sensors "Jon Medhurst (Tixy)" <tixy@linaro.org> - 2015-09-15 13:40 +0200
                Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-15 18:10 +0200
                Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI  sensors "Jon Medhurst (Tixy)" <tixy@linaro.org> - 2015-09-15 18:40 +0200
  [PATCH v3 5/5] arm64: dts: Add sensor node to Juno dt Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 15:20 +0200
  [PATCH v3 4/5] hwmon: Support thermal zones registration for SCP temperature sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 15:20 +0200
  [Patch v3 4/5] hwmon: Support registration of thermal zones for SCP temperature sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 15:20 +0200
    Re: [Patch v3 4/5] hwmon: Support registration of thermal zones for SCP temperature sensors Punit Agrawal <punit.agrawal@arm.com> - 2015-09-14 15:20 +0200

csiph-web