Re: [PATCH 5/5] virtgpu: mark as a render gpu

From	Emil Velikov <emil.l.velikov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] virtgpu: mark as a render gpu
Date	2015-09-10 16:40 +0200
Message-ID	<q7bb3-4eD-15@gated-at.bofh.it> (permalink)
References	<q6M2Z-1ZO-3@gated-at.bofh.it> <q6M31-1ZO-27@gated-at.bofh.it> <q75S2-4Wf-1@gated-at.bofh.it> <q7b1o-43t-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10 September 2015 at 15:23, Gerd Hoffmann <kraxel@redhat.com> wrote:
> On Do, 2015-09-10 at 09:59 +0100, Emil Velikov wrote:
>> On 9 September 2015 at 12:42, Gerd Hoffmann <kraxel@redhat.com> wrote:
>> > From: Dave Airlie <airlied@redhat.com>
>> >
>> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> > ---
>> >  drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/drivers/gpu/drm/virtio/virtgpu_drv.c
>> > index 1245d09..e00298e 100644
>> > --- a/drivers/gpu/drm/virtio/virtgpu_drv.c
>> > +++ b/drivers/gpu/drm/virtio/virtgpu_drv.c
>> > @@ -113,7 +113,7 @@ static const struct file_operations virtio_gpu_driver_fops = {
>> >
>> >
>> >  static struct drm_driver driver = {
>> > -       .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_PRIME,
>> > +       .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_PRIME | DRIVER_RENDER,
>>
>> I believe that this will only create the renderD# node. Shouldn't one
>> also tag the relevant ioctls with DRM_RENDER_ALLOW ?
>
> Dave?  Looking at the ioctls they are all fine for render nodes, there
> isn't anything modesetting related in the device-specific ioctls.
>
> Correct?
>
Unless I've overdone the coffee this time - modesetting is done via
the card# node, while render via either card# or renderD#.

So I'm suspecting that you're using card# node which would explain why
things work. Otherwise drm_ioctl_permit will bail out with -EACCESS.

Regards,
Emil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 5/5] virtgpu: mark as a render gpu Gerd Hoffmann <kraxel@redhat.com> - 2015-09-09 13:50 +0200
  Re: [PATCH 5/5] virtgpu: mark as a render gpu Emil Velikov <emil.l.velikov@gmail.com> - 2015-09-10 11:00 +0200
    Re: [PATCH 5/5] virtgpu: mark as a render gpu Gerd Hoffmann <kraxel@redhat.com> - 2015-09-10 16:30 +0200
      Re: [PATCH 5/5] virtgpu: mark as a render gpu Emil Velikov <emil.l.velikov@gmail.com> - 2015-09-10 16:40 +0200
        Re: [PATCH 5/5] virtgpu: mark as a render gpu Gerd Hoffmann <kraxel@redhat.com> - 2015-09-10 17:00 +0200
          Re: [PATCH 5/5] virtgpu: mark as a render gpu Emil Velikov <emil.l.velikov@gmail.com> - 2015-09-10 17:10 +0200
            Re: [PATCH 5/5] virtgpu: mark as a render gpu Dave Airlie <airlied@gmail.com> - 2015-09-11 08:40 +0200
              Re: [PATCH 5/5] virtgpu: mark as a render gpu Gerd Hoffmann <kraxel@redhat.com> - 2015-09-11 11:20 +0200

csiph-web