Re: [PATCH 5/5] virtgpu: mark as a render gpu

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Emil Velikov <emil.l.velikov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] virtgpu: mark as a render gpu
Date	Thu, 10 Sep 2015 16:40:01 +0200
Message-ID	<q7bb3-4eD-15@gated-at.bofh.it> (permalink)
References	<q6M2Z-1ZO-3@gated-at.bofh.it> <q6M31-1ZO-27@gated-at.bofh.it> <q75S2-4Wf-1@gated-at.bofh.it> <q7b1o-43t-23@gated-at.bofh.it>
X-Original-To	Gerd Hoffmann <kraxel@redhat.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=K7EM8jV7voTMmnynHrzy0t4C3JUggm/l8mYDoJ5rVsU=; b=W+qRQNfbBIe4FdfY+2Vd2OzRG3PcPBG+/3EEq9P2yQCfmtRj1AgYfjlIQUBQEPRA2Z 1BEAvVtGmc3tOW66sAMbZ0NtvC45l2NsTuJj66SjU4fBzQHrD1f4FUyvN+OqmhkaHZUp 4Crt/R66eaOVza+nQFR7rCIE6yXbCw9bphdi4oSal6ye3k/veCKXIW/buLhRZHPLcHJJ gxZBDNJf2KQ22/qLYACq3N45M8ElCl9tCtFOmLEP8cXkX/Yil4y/jqP6uVMhqGcIEvbs jV3jQ/5FCCFAz95eCmvtN22sBLZDDX1IKJ6Od+cKzrGcfKE+9HasBGOzGNTu6V1OYebG tRrw==
MIME-Version	1.0
X-Received	by 10.50.29.101 with SMTP id j5mr6641830igh.70.1441895595518; Thu, 10 Sep 2015 07:33:15 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	ML dri-devel <dri-devel@lists.freedesktop.org>, Dave Airlie <airlied@redhat.com>, open list <linux-kernel@vger.kernel.org>, "open list:VIRTIO GPU DRIVER" <virtualization@lists.linux-foundation.org>
X-Original-Date	Thu, 10 Sep 2015 15:33:15 +0100
X-Original-Message-ID	<CACvgo50SU46SYXBbVe+VGcAb6uFSj-iBY0E4=Vuuzf5RKbE+2Q@mail.gmail.com>
X-Original-References	<1441798946-26233-1-git-send-email-kraxel@redhat.com> <1441798946-26233-6-git-send-email-kraxel@redhat.com> <CACvgo53wYvAk_bVouPZ-F7wNm=Diyouue8m1AvO0=U+PvL61_Q@mail.gmail.com> <1441895002.11233.6.camel@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1222237

Show key headers only | View raw

On 10 September 2015 at 15:23, Gerd Hoffmann <kraxel@redhat.com> wrote:
> On Do, 2015-09-10 at 09:59 +0100, Emil Velikov wrote:
>> On 9 September 2015 at 12:42, Gerd Hoffmann <kraxel@redhat.com> wrote:
>> > From: Dave Airlie <airlied@redhat.com>
>> >
>> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> > ---
>> >  drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/drivers/gpu/drm/virtio/virtgpu_drv.c
>> > index 1245d09..e00298e 100644
>> > --- a/drivers/gpu/drm/virtio/virtgpu_drv.c
>> > +++ b/drivers/gpu/drm/virtio/virtgpu_drv.c
>> > @@ -113,7 +113,7 @@ static const struct file_operations virtio_gpu_driver_fops = {
>> >
>> >
>> >  static struct drm_driver driver = {
>> > -       .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_PRIME,
>> > +       .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_PRIME | DRIVER_RENDER,
>>
>> I believe that this will only create the renderD# node. Shouldn't one
>> also tag the relevant ioctls with DRM_RENDER_ALLOW ?
>
> Dave?  Looking at the ioctls they are all fine for render nodes, there
> isn't anything modesetting related in the device-specific ioctls.
>
> Correct?
>
Unless I've overdone the coffee this time - modesetting is done via
the card# node, while render via either card# or renderD#.

So I'm suspecting that you're using card# node which would explain why
things work. Otherwise drm_ioctl_permit will bail out with -EACCESS.

Regards,
Emil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 5/5] virtgpu: mark as a render gpu Gerd Hoffmann <kraxel@redhat.com> - 2015-09-09 13:50 +0200
  Re: [PATCH 5/5] virtgpu: mark as a render gpu Emil Velikov <emil.l.velikov@gmail.com> - 2015-09-10 11:00 +0200
    Re: [PATCH 5/5] virtgpu: mark as a render gpu Gerd Hoffmann <kraxel@redhat.com> - 2015-09-10 16:30 +0200
      Re: [PATCH 5/5] virtgpu: mark as a render gpu Emil Velikov <emil.l.velikov@gmail.com> - 2015-09-10 16:40 +0200
        Re: [PATCH 5/5] virtgpu: mark as a render gpu Gerd Hoffmann <kraxel@redhat.com> - 2015-09-10 17:00 +0200
          Re: [PATCH 5/5] virtgpu: mark as a render gpu Emil Velikov <emil.l.velikov@gmail.com> - 2015-09-10 17:10 +0200
            Re: [PATCH 5/5] virtgpu: mark as a render gpu Dave Airlie <airlied@gmail.com> - 2015-09-11 08:40 +0200
              Re: [PATCH 5/5] virtgpu: mark as a render gpu Gerd Hoffmann <kraxel@redhat.com> - 2015-09-11 11:20 +0200

csiph-web