possible new false positive in checkpatch

From	Tal Shorer <tal.shorer@gmail.com>
Newsgroups	linux.kernel
Subject	possible new false positive in checkpatch
Date	2015-09-12 14:20 +0200
Message-ID	<q7RWG-ds-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Since my last pull from upstream (today) , I started seeing some
checkpatch warnings regarding suspect code indent I believe are false
positive. Take this code for example:

static int foo(void)
{
	while (bar())
		/* do nothing */;
}

When running checkpath on it, the following warning is emitted:

tal@tal:~/Dev/lfs/linux|0 $ scripts/checkpatch.pl -f ~/tmp/foo.c
WARNING: suspect code indent for conditional statements (8, 32)
#3: FILE: /home/tal/tmp/foo.c:3:
+	while (bar())
+		/* do nothing */;

total: 0 errors, 1 warnings, 5 lines checked

/home/tal/tmp/foo.c has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
tal@tal:~/Dev/lfs/linux|1 $ 

Using my limited perl knowledge, I believe the lines causing this are
3111-3133:
			# remove inline comments
			$s =~ s/$;/ /g;
			$c =~ s/$;/ /g;
Introduced in commit 9f5af480f4554aac12e002b6f5c2b04895857700:
checkpatch: improve SUSPECT_CODE_INDENT test
Commenting out these lines removes the warning.

This pattern exists in many places around the kernel source.
Is this the intended behavior?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

possible new false positive in checkpatch Tal Shorer <tal.shorer@gmail.com> - 2015-09-12 14:20 +0200
  Re: possible new false positive in checkpatch Andy Whitcroft <apw@canonical.com> - 2015-09-14 12:30 +0200
    Re: possible new false positive in checkpatch Tal Shorer <tal.shorer@gmail.com> - 2015-09-15 17:00 +0200
      Re: possible new false positive in checkpatch Andy Whitcroft <apw@canonical.com> - 2015-09-15 17:10 +0200

csiph-web