Re: possible new false positive in checkpatch

From	Andy Whitcroft <apw@canonical.com>
Newsgroups	linux.kernel
Subject	Re: possible new false positive in checkpatch
Date	2015-09-15 17:10 +0200
Message-ID	<q901Q-8qX-33@gated-at.bofh.it> (permalink)
References	<q7RWG-ds-5@gated-at.bofh.it> <q8zbk-3r6-15@gated-at.bofh.it> <q8ZSa-7YI-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 15, 2015 at 05:50:40PM +0300, Tal Shorer wrote:

> > Yes it feels like that should be eliding them completely, and likely any
> > following space as well, something like this:
> >
> >         $s =~ s/$;+\s*//g;
> >         $c =~ s/$;+\s*//g;
> >
> Replacing the problematic lines with these fixes the issue.
> > > Introduced in commit 9f5af480f4554aac12e002b6f5c2b04895857700:
> > > checkpatch: improve SUSPECT_CODE_INDENT test
> > > Commenting out these lines removes the warning.
> > >
> > > This pattern exists in many places around the kernel source.
> > > Is this the intended behavior?
> >
> > Seems wrong to me.
> >
> > -apw
> 
> Which git tree is checkpatch developed in? Linus's?

Yeah in Linus' tree.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

possible new false positive in checkpatch Tal Shorer <tal.shorer@gmail.com> - 2015-09-12 14:20 +0200
  Re: possible new false positive in checkpatch Andy Whitcroft <apw@canonical.com> - 2015-09-14 12:30 +0200
    Re: possible new false positive in checkpatch Tal Shorer <tal.shorer@gmail.com> - 2015-09-15 17:00 +0200
      Re: possible new false positive in checkpatch Andy Whitcroft <apw@canonical.com> - 2015-09-15 17:10 +0200

csiph-web