Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1220331

Re: [PATCH v2] irqchip, gicv3-its, numa: Workaround for Cavium ThunderX erratum 23144

From Robert Richter <robert.richter@caviumnetworks.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] irqchip, gicv3-its, numa: Workaround for Cavium ThunderX erratum 23144
Date 2015-09-07 18:50 +0200
Message-ID <q67Me-2Kt-9@gated-at.bofh.it> (permalink)
References <q1k7o-4eG-15@gated-at.bofh.it> <q67Me-2Kt-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 07.09.15 17:44:41, Marc Zyngier wrote:
> On 25/08/15 11:18, Ganapatrao Kulkarni wrote:
> > The patch below adds a workaround for gicv3 in a numa environment. It
> > is on top of Robert's recent gicv3 errata patch submission v4 and my
> > arm64 numa patches v5.
> > 
> > This implements a workaround for gicv3-its erratum 23144 on Cavium's
> > ThunderX dual-socket platforms, where LPI cannot be routed to a
> > redistributors present on a foreign node.
> > 
> > v2:
> > updatated as per Marc Zyngier's review comments.
> > 
> > Signed-off-by: Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>
> > Signed-off-by: Robert Richter <rrichter@cavium.com>
> > ---
> >  drivers/irqchip/irq-gic-v3-its.c | 53 +++++++++++++++++++++++++++++++++-------
> >  1 file changed, 44 insertions(+), 9 deletions(-)
> > 
> > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> > index 614a367..d3fe0a4 100644
> > --- a/drivers/irqchip/irq-gic-v3-its.c
> > +++ b/drivers/irqchip/irq-gic-v3-its.c
> > @@ -40,7 +40,8 @@
> >  #include "irqchip.h"
> >  
> >  #define ITS_FLAGS_CMDQ_NEEDS_FLUSHING          (1ULL << 0)
> > -#define ITS_FLAGS_CAVIUM_THUNDERX              (1ULL << 1)
> > +#define ITS_WORKAROUND_CAVIUM_22375            (1ULL << 1)
> > +#define ITS_WORKAROUND_CAVIUM_23144            (1ULL << 2)
> 
> Please move this to Robert's series, as it doesn't make much sense to
> add a quirk flag just to modify it in the next patch. This will help
> declutter this patch.

I will merge the bits in and rebase and rework this one on top (we
will post this separately due to dependencies to other patch sets).

Thanks,

-Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] irqchip, gicv3-its, numa: Workaround for Cavium ThunderX erratum 23144 Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com> - 2015-08-25 13:00 +0200
  Re: [PATCH v2] irqchip, gicv3-its, numa: Workaround for Cavium  ThunderX erratum 23144 Robert Richter <robert.richter@caviumnetworks.com> - 2015-09-07 18:50 +0200
  Re: [PATCH v2] irqchip, gicv3-its, numa: Workaround for Cavium ThunderX  erratum 23144 Marc Zyngier <marc.zyngier@arm.com> - 2015-09-07 18:50 +0200

csiph-web