Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1220151

Re: [PATCH 3/5] staging: most: remove driver owner

Show all headers | View raw

On Mon, Sep 07, 2015 at 02:13:38PM +0200, Andrey Shvetsov wrote:
> On Fri, Sep 04, 2015 at 04:22:04PM +0530, Sudip Mukherjee wrote:
> > The platform driver core will set the owner value, we do not need to do
> > it in the module.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> >  drivers/staging/most/hdm-dim2/dim2_hdm.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c b/drivers/staging/most/hdm-dim2/dim2_hdm.c
> > index 5b0a588..4481a0b 100644
> > --- a/drivers/staging/most/hdm-dim2/dim2_hdm.c
> > +++ b/drivers/staging/most/hdm-dim2/dim2_hdm.c
> > @@ -923,7 +923,6 @@ static struct platform_driver dim2_driver = {
> >  	.id_table = dim2_id,
> >  	.driver = {
> >  		.name = "hdm_dim2",
> > -		.owner = THIS_MODULE,
> I cannot accept this.
> 
> This change is not significant for current kernel, but we still have customers
> using kernels <= 3.10, where auto assignment of .owner does not exist.
But this patch is for 4.4-rc1, and it is not marked for stable. Then how
is it going to affect your customers who are still using <=3.10?

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] staging: most: remove always true comparison Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-04 13:00 +0200
  [PATCH 3/5] staging: most: remove driver owner Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-04 13:00 +0200
    Re: [PATCH 3/5] staging: most: remove driver owner Andrey Shvetsov <andrey.shvetsov@k2l.de> - 2015-09-07 14:20 +0200
      Re: [PATCH 3/5] staging: most: remove driver owner Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-07 14:50 +0200
        Re: [PATCH 3/5] staging: most: remove driver owner Andrey Shvetsov <andrey.shvetsov@k2l.de> - 2015-09-08 12:00 +0200
          Re: [PATCH 3/5] staging: most: remove driver owner Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-09-08 18:50 +0200
  [PATCH 5/5] staging: most: style of bool comparison Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-04 13:00 +0200

csiph-web