Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1220151
| Path | csiph.com!au2pb.net!feeder.erje.net!us.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/5] staging: most: remove driver owner |
| Date | Mon, 07 Sep 2015 14:50:02 +0200 |
| Message-ID | <q641Y-5PD-19@gated-at.bofh.it> (permalink) |
| References | <q4WSS-8hy-7@gated-at.bofh.it> <q4WST-8hy-37@gated-at.bofh.it> <q63yW-5hl-31@gated-at.bofh.it> |
| X-Original-To | Andrey Shvetsov <andrey.shvetsov@k2l.de> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=xsa0URTHZxBxLFKmzmlxtN5rnRyV/RivZio9B8vnMhU=; b=WxFPiXFH0ZB+VghM3KfolsvKeJ4Jlj9Y1QAuZp8PmUGIEac3TZAnwk53qvVqvomToZ 6xCt8h2FoFTH1sIPE++XW7Cz/1/Z5Mubhs1ibDAVzWdLl5GA2KDCpdu86kmQDkHfDoKW O8AbcHw+9Q0l3q/hxNP2dkbF0anopTDcvRMdudnq+XBVjDnllToBK6MAxIdb8lnS9LxS rxkKmgODuHaRujDvdk7OP343+x1rAvOEt0Hm9Qq48fWo0nPexgKU/vmq1aW1lwJrleYt etXaFm6WwdzPRFGoYBUM1azblUtW7M101U1YHlKElYbbTai6xz+1bKykL45ywqcJJdMK AO7w== |
| X-Received | by 10.68.69.98 with SMTP id d2mr44667031pbu.137.1441629991142; Mon, 07 Sep 2015 05:46:31 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2010-09-15) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 33 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| X-Original-Date | Mon, 7 Sep 2015 18:16:21 +0530 |
| X-Original-Message-ID | <20150907124621.GA16559@sudip-pc> |
| X-Original-References | <1441363926-5025-1-git-send-email-sudipm.mukherjee@gmail.com> <1441363926-5025-3-git-send-email-sudipm.mukherjee@gmail.com> <20150907121337.GA6992@KAR-DK-M21181> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1220151 |
Show key headers only | View raw
On Mon, Sep 07, 2015 at 02:13:38PM +0200, Andrey Shvetsov wrote:
> On Fri, Sep 04, 2015 at 04:22:04PM +0530, Sudip Mukherjee wrote:
> > The platform driver core will set the owner value, we do not need to do
> > it in the module.
> >
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> > drivers/staging/most/hdm-dim2/dim2_hdm.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c b/drivers/staging/most/hdm-dim2/dim2_hdm.c
> > index 5b0a588..4481a0b 100644
> > --- a/drivers/staging/most/hdm-dim2/dim2_hdm.c
> > +++ b/drivers/staging/most/hdm-dim2/dim2_hdm.c
> > @@ -923,7 +923,6 @@ static struct platform_driver dim2_driver = {
> > .id_table = dim2_id,
> > .driver = {
> > .name = "hdm_dim2",
> > - .owner = THIS_MODULE,
> I cannot accept this.
>
> This change is not significant for current kernel, but we still have customers
> using kernels <= 3.10, where auto assignment of .owner does not exist.
But this patch is for 4.4-rc1, and it is not marked for stable. Then how
is it going to affect your customers who are still using <=3.10?
regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/5] staging: most: remove always true comparison Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-04 13:00 +0200
[PATCH 3/5] staging: most: remove driver owner Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-04 13:00 +0200
Re: [PATCH 3/5] staging: most: remove driver owner Andrey Shvetsov <andrey.shvetsov@k2l.de> - 2015-09-07 14:20 +0200
Re: [PATCH 3/5] staging: most: remove driver owner Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-07 14:50 +0200
Re: [PATCH 3/5] staging: most: remove driver owner Andrey Shvetsov <andrey.shvetsov@k2l.de> - 2015-09-08 12:00 +0200
Re: [PATCH 3/5] staging: most: remove driver owner Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-09-08 18:50 +0200
[PATCH 5/5] staging: most: style of bool comparison Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-04 13:00 +0200
csiph-web