Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216146

Re: [PATCH V7 6/8] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D

Show all headers | View raw

On Fri, Aug 28, 2015 at 05:48:07AM -0400, Kan Liang wrote:

SNIP

>  
>  static struct machine *machines__find_for_cpumode(struct machines *machines,
> @@ -1079,11 +1101,12 @@ static int machines__deliver_event(struct machines *machines,
>  
>  	switch (event->header.type) {
>  	case PERF_RECORD_SAMPLE:
> -		dump_sample(evsel, event, sample);
>  		if (evsel == NULL) {
>  			++evlist->stats.nr_unknown_id;
>  			return 0;
>  		}
> +		dump_sample(evsel, event, sample);
> +

could you submit this hunk separately.. seems like we could
segfault in dump_sample if there's evsel == NULL, right?

jirka

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V7 0/8] Freq/CPU%/CORE_BUSY% support Kan Liang <kan.liang@intel.com> - 2015-08-28 19:10 +0200
  [PATCH V7 4/8] perf,tools: add backpointer for perf_env to evlist Kan Liang <kan.liang@intel.com> - 2015-08-28 19:10 +0200
    Re: [PATCH V7 4/8] perf,tools: add backpointer for perf_env to evlist Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-28 19:50 +0200
    [tip:perf/core] perf evlist:   Add backpointer for perf_env to evlist tip-bot for Kan Liang <tipbot@zytor.com> - 2015-08-31 10:40 +0200
  [PATCH V7 6/8] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D Kan Liang <kan.liang@intel.com> - 2015-08-28 19:10 +0200
    Re: [PATCH V7 6/8] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY%  in report -D Jiri Olsa <jolsa@redhat.com> - 2015-08-31 13:20 +0200
      RE: [PATCH V7 6/8] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY%  in report -D "Liang, Kan" <kan.liang@intel.com> - 2015-08-31 21:20 +0200
    Re: [PATCH V7 6/8] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY%  in report -D Jiri Olsa <jolsa@redhat.com> - 2015-08-31 13:20 +0200
      Re: [PATCH V7 6/8] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY%  in report -D Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-31 22:40 +0200
  [PATCH V7 3/8] perf,tools: rename perf_session_env to perf_env Kan Liang <kan.liang@intel.com> - 2015-08-28 19:10 +0200
    Re: [PATCH V7 3/8] perf,tools: rename perf_session_env to perf_env Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-28 19:50 +0200
    [tip:perf/core] perf tools: Rename perf_session_env to perf_env tip-bot for Kan Liang <tipbot@zytor.com> - 2015-08-31 10:40 +0200
  [PATCH V7 5/8] perf evsel: Add a backpointer to the evlist a evsel is in Kan Liang <kan.liang@intel.com> - 2015-08-28 19:10 +0200
    Re: [PATCH V7 5/8] perf evsel: Add a backpointer to the evlist a  evsel is in Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-28 19:50 +0200
  [PATCH V7 8/8] perf,tools: Show freq/CPU%/CORE_BUSY% in perf report --stdio Kan Liang <kan.liang@intel.com> - 2015-08-28 19:10 +0200
  [PATCH V7 1/8] perf,tools: introduce generic FEAT for CPU attributes Kan Liang <kan.liang@intel.com> - 2015-08-28 19:10 +0200
    Re: [PATCH V7 1/8] perf,tools: introduce generic FEAT for CPU  attributes Jiri Olsa <jolsa@redhat.com> - 2015-08-31 11:50 +0200

csiph-web