Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216126

Re: [PATCH V7 1/8] perf,tools: introduce generic FEAT for CPU attributes

Show all headers | View raw

On Fri, Aug 28, 2015 at 05:48:02AM -0400, Kan Liang wrote:

SNIP

>  
> +static int process_cpu_attributes(struct perf_file_section *section __maybe_unused,
> +				  struct perf_header *ph, int fd,
> +				  void *data __maybe_unused)
> +{
> +	ssize_t ret;
> +	u32 i, tag_id;
> +	u64 nr;
> +
> +	for (i = 0; i < PERF_HEADER_CPU_ATTR_MAX; i++) {
> +
> +		ret = readn(fd, &tag_id, sizeof(tag_id));
> +		if (ret != sizeof(tag_id))
> +			return -1;
> +
> +		if (ph->needs_swap)
> +			nr = bswap_32(tag_id);
> +
> +		if (tag_id >= PERF_HEADER_CPU_ATTR_MAX) {
> +			pr_debug("The number of cpu attributes is not expected. "
> +				 "You may need to upgrade the perf tool.\n");
> +			return -1;
> +		}

I wonder we should let it pass to be able to read new data
with older perf.. but IMO the error is specific enough to
find & fix it if it ever happens

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V7 0/8] Freq/CPU%/CORE_BUSY% support Kan Liang <kan.liang@intel.com> - 2015-08-28 19:10 +0200
  [PATCH V7 4/8] perf,tools: add backpointer for perf_env to evlist Kan Liang <kan.liang@intel.com> - 2015-08-28 19:10 +0200
    Re: [PATCH V7 4/8] perf,tools: add backpointer for perf_env to evlist Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-28 19:50 +0200
    [tip:perf/core] perf evlist:   Add backpointer for perf_env to evlist tip-bot for Kan Liang <tipbot@zytor.com> - 2015-08-31 10:40 +0200
  [PATCH V7 6/8] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D Kan Liang <kan.liang@intel.com> - 2015-08-28 19:10 +0200
    Re: [PATCH V7 6/8] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY%  in report -D Jiri Olsa <jolsa@redhat.com> - 2015-08-31 13:20 +0200
      RE: [PATCH V7 6/8] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY%  in report -D "Liang, Kan" <kan.liang@intel.com> - 2015-08-31 21:20 +0200
    Re: [PATCH V7 6/8] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY%  in report -D Jiri Olsa <jolsa@redhat.com> - 2015-08-31 13:20 +0200
      Re: [PATCH V7 6/8] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY%  in report -D Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-31 22:40 +0200
  [PATCH V7 3/8] perf,tools: rename perf_session_env to perf_env Kan Liang <kan.liang@intel.com> - 2015-08-28 19:10 +0200
    Re: [PATCH V7 3/8] perf,tools: rename perf_session_env to perf_env Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-28 19:50 +0200
    [tip:perf/core] perf tools: Rename perf_session_env to perf_env tip-bot for Kan Liang <tipbot@zytor.com> - 2015-08-31 10:40 +0200
  [PATCH V7 5/8] perf evsel: Add a backpointer to the evlist a evsel is in Kan Liang <kan.liang@intel.com> - 2015-08-28 19:10 +0200
    Re: [PATCH V7 5/8] perf evsel: Add a backpointer to the evlist a  evsel is in Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-28 19:50 +0200
  [PATCH V7 8/8] perf,tools: Show freq/CPU%/CORE_BUSY% in perf report --stdio Kan Liang <kan.liang@intel.com> - 2015-08-28 19:10 +0200
  [PATCH V7 1/8] perf,tools: introduce generic FEAT for CPU attributes Kan Liang <kan.liang@intel.com> - 2015-08-28 19:10 +0200
    Re: [PATCH V7 1/8] perf,tools: introduce generic FEAT for CPU  attributes Jiri Olsa <jolsa@redhat.com> - 2015-08-31 11:50 +0200

csiph-web