Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal

From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal
Date	2015-08-29 13:20 +0200
Message-ID	<q2MkV-a6-7@gated-at.bofh.it> (permalink)
References	<q0IYa-1r5-15@gated-at.bofh.it> <q11Hr-32x-3@gated-at.bofh.it> <q14Fj-7f0-7@gated-at.bofh.it> <q2AD8-8vL-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:

> Robert,
>
> On 24 August 2015 at 15:24, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>> Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:
>>
>>> Should we worry about having two definitions for the same bit?
>>> Would it be too ugly to mix the two meaning? Something like this:
>>>
>>> /* This bit has two different meanings on NFCv1 and NFCv2 */
>>> #define NDCR_STOP_ON_UNCOR_ARB_CNTL (0x1 << 19)
>> I don't find that very pretty, but if you want I can put that in the patch
>> instead.
>>
>
> Yeah, it's far from pretty.
>
> OK, another idea. How about this:
>
> #define NFCV2_NDCR_STOP_ON_UNCOR (0x1 << 19)
> #define NFCV1_NDCR_ARB_CNTL      (0x1 << 19)
This one looks much more prettier, I'll take it.

> That'll work. Feel free to send a v2.
Okay, I'm on my way.

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-23 21:20 +0200
  Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2015-08-24 17:20 +0200
    Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-24 20:30 +0200
      Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2015-08-29 00:50 +0200
        Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-29 13:20 +0200

csiph-web