Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal
Date	Sat, 29 Aug 2015 13:20:01 +0200
Message-ID	<q2MkV-a6-7@gated-at.bofh.it> (permalink)
References	<q0IYa-1r5-15@gated-at.bofh.it> <q11Hr-32x-3@gated-at.bofh.it> <q14Fj-7f0-7@gated-at.bofh.it> <q2AD8-8vL-3@gated-at.bofh.it>
X-Original-To	Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
X-Me-Helo	belgarion
X-Me-Auth	amFyem1pay5yb2JlcnRAb3JhbmdlLmZy
X-Me-Date	Sat, 29 Aug 2015 13:11:53 +0200
X-Me-IP	109.222.68.49
X-URL	http://belgarath.falguerolles.org/
User-Agent	Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux)
MIME-Version	1.0
Content-Type	text/plain
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>, David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, "linux-mtd\@lists.infradead.org" <linux-mtd@lists.infradead.org>, "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Sat, 29 Aug 2015 13:07:28 +0200
X-Original-Message-ID	<87pp261hfz.fsf@belgarion.home>
X-Original-References	<1440356741-24308-1-git-send-email-robert.jarzmik@free.fr> <20150824150847.GA8497@laptop.cereza> <87io8435q4.fsf@belgarion.home> <CAAEAJfDCUGDbssCkQEazcJLuvJWjbSxKDix9ts4peSZ8Xk1ZOA@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1215765

Show key headers only | View raw

Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:

> Robert,
>
> On 24 August 2015 at 15:24, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>> Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:
>>
>>> Should we worry about having two definitions for the same bit?
>>> Would it be too ugly to mix the two meaning? Something like this:
>>>
>>> /* This bit has two different meanings on NFCv1 and NFCv2 */
>>> #define NDCR_STOP_ON_UNCOR_ARB_CNTL (0x1 << 19)
>> I don't find that very pretty, but if you want I can put that in the patch
>> instead.
>>
>
> Yeah, it's far from pretty.
>
> OK, another idea. How about this:
>
> #define NFCV2_NDCR_STOP_ON_UNCOR (0x1 << 19)
> #define NFCV1_NDCR_ARB_CNTL      (0x1 << 19)
This one looks much more prettier, I'll take it.

> That'll work. Feel free to send a v2.
Okay, I'm on my way.

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-23 21:20 +0200
  Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2015-08-24 17:20 +0200
    Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-24 20:30 +0200
      Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2015-08-29 00:50 +0200
        Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-29 13:20 +0200

csiph-web