Re: [PATCH] ARC: add negative dependency for VGA_CONSOLE

From	Vineet Gupta <Vineet.Gupta1@synopsys.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARC: add negative dependency for VGA_CONSOLE
Date	2015-08-25 09:50 +0200
Message-ID	<q1h9v-8th-5@gated-at.bofh.it> (permalink)
References	<pYuZk-3nQ-21@gated-at.bofh.it> <pYvsm-4bw-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday 17 August 2015 09:51 PM, Geert Uytterhoeven wrote:
> On Mon, Aug 17, 2015 at 5:52 PM, Yuriy Kolerov
> <yuriy.kolerov@synopsys.com> wrote:
>> Architectures which support VGA console must define screen_info
>> structurture from "uapi/linux/screen_info.h". Otherwise undefined
>> symbol error occurs. Usually it's defined in "setup.c" for each
>> architecture.
>>
>> If an architecture does not support VGA console (ARC's case)
>> there are 2 ways: define a dummy instance of screen_info or add
>> a negative dependency for VGA_CONSOLE in to prevent selecting
>> this option.
>>
>> I've implemented the second way. However the best solution is to
>> add HAVE_VGA_CONSOLE option for targets which support VGA
>> console. Then turn off VGA_CONSOLE by default and add dependency
>> to HAVE_VGA_CONSOLE. But right now it's better to just add a
>> negative dependency for ARC and then consider how to collaborate
>> about this issue with maintainers of other architectures.
> +1
>
>> Signed-off-by: Yuriy Kolerov <yuriy.kolerov@synopsys.com>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Hi Tomi,

Is anything else needed for this to be merged.

Thx,
-Vineet

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ARC: add negative dependency for VGA_CONSOLE Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-08-25 09:50 +0200
  Re: [PATCH] ARC: add negative dependency for VGA_CONSOLE Tomi Valkeinen <tomi.valkeinen@ti.com> - 2015-08-26 13:40 +0200

csiph-web