Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1212772

Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h

From Chen-Yu Tsai <wens@csie.org>
Newsgroups linux.kernel
Subject Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h
Date 2015-08-25 09:50 +0200
Message-ID <q1h9w-8th-21@gated-at.bofh.it> (permalink)
References <pYJlE-7Ap-31@gated-at.bofh.it> <q17tw-31O-21@gated-at.bofh.it> <q1cCR-21v-3@gated-at.bofh.it> <q1gn8-7jI-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Aug 25, 2015 at 2:59 PM, Michal Kubecek <mkubecek@suse.cz> wrote:
> On Tue, Aug 25, 2015 at 10:55:28AM +0800, Chen-Yu Tsai wrote:
>> On Tue, Aug 25, 2015 at 5:28 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> > On 08/18, Chen-Yu Tsai wrote:
>> >> of_clk_set_defaults uses the type 'bool', but clk-conf.h does not
>> >> include its definition.
>> >>
>> >> This results in a compile error when only clk-conf.h is used.
>> >>
>> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>> >> Cc: stable@vger.kernel.org
>> >
>> > Why is stable Cc-ed? Is there some sort of compilation failure on
>> > stable kernels?
>>
>> There isn't for now. Though I don't see why we shouldn't fix this for
>> stable kernels as well. It's possible other people or third-party
>> vendors working with stable/LTS kernels (Android?) may run into it.
>
> How about
>
>    - It must fix a real bug that bothers people (not a, "This could be a
>    problem..." type thing).
>
> in Documentation/stable_kernel_rules.txt?

My bad. I'll send a new version without the CC.

ChenYu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] clk: Add missing header for 'bool' definition to  clk-conf.h Stephen Boyd <sboyd@codeaurora.org> - 2015-08-24 23:30 +0200
  Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h Chen-Yu Tsai <wens@csie.org> - 2015-08-25 05:00 +0200
    Re: [PATCH] clk: Add missing header for 'bool' definition to  clk-conf.h Michal Kubecek <mkubecek@suse.cz> - 2015-08-25 09:00 +0200
      Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h Chen-Yu Tsai <wens@csie.org> - 2015-08-25 09:50 +0200
        Re: [PATCH] clk: Add missing header for 'bool' definition to  clk-conf.h Stephen Boyd <sboyd@codeaurora.org> - 2015-08-25 20:00 +0200

csiph-web