Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1161108

Re: [42/73] rtc: delete non-required instances of include <linux/init.h>

From Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [42/73] rtc: delete non-required instances of include <linux/init.h>
Date 2015-06-09 10:00 +0200
Message-ID <pzmBX-a8-11@gated-at.bofh.it> (permalink)
References <mCR3v-7Oq-75@gated-at.bofh.it> <pzbnc-pK-13@gated-at.bofh.it> <pzcsW-2dO-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 08/06/2015 at 17:06:34 -0400, Paul Gortmaker wrote :
> > I've contemplated applying that patch but I'm not sure it is actually a
> > good idea because those 46 drivers are using a variant of module_driver
> > which actually uses __init and __exit. After your patch it is still
> > working simply because init.h gets included that way:
> 
> Firstly, I am kind of curious why an 18 month old patch is getting
> replied to now.   That aside, this interdependence between module.h and
> init.h was reconsidered and you can see the resolution solution here:
> 
> https://lkml.kernel.org/r/1433276168-21550-1-git-send-email-paul.gortmaker@windriver.com
> 
> To summarize what is said there, yes - you can ignore the one line
> removals for now.  We will revisit them after the above is merged.
> 

I've taken the RTC subsystem maintainership and I've been sorting the
2372 patches left in patchwork down to 126 and yours was one of these.

Seeing your answer, I think my question was legitimate. I'll be happy to
take your revised patch once ready.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [42/73] rtc: delete non-required instances of include  <linux/init.h> Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-06-08 22:00 +0200
  Re: [42/73] rtc: delete non-required instances of include  <linux/init.h> Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-06-09 10:00 +0200
    Re: [42/73] rtc: delete non-required instances of include <linux/init.h> Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-06-10 04:00 +0200

csiph-web