Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1160747

Re: [42/73] rtc: delete non-required instances of include <linux/init.h>

Show all headers | View raw

On 21/01/2014 at 16:22:45 -0500, Paul Gortmaker wrote :
> None of these files are actually using any __init type directives
> and hence don't need to include <linux/init.h>.  Most are just a
> left over from __devinit and __cpuinit removal, or simply due to
> code getting copied from one driver to the next.
> 
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: rtc-linux@googlegroups.com
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

I've contemplated applying that patch but I'm not sure it is actually a
good idea because those 46 drivers are using a variant of module_driver
which actually uses __init and __exit. After your patch it is still
working simply because init.h gets included that way:

linux/module.h:9
linux/list.h:8
linux/kernel.h:13
linux/printk.h:5

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [42/73] rtc: delete non-required instances of include  <linux/init.h> Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-06-08 22:00 +0200
  Re: [42/73] rtc: delete non-required instances of include  <linux/init.h> Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-06-09 10:00 +0200
    Re: [42/73] rtc: delete non-required instances of include <linux/init.h> Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-06-10 04:00 +0200

csiph-web