Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()
Date	2015-06-11 02:50 +0200
Message-ID	<pzYQW-6ff-3@gated-at.bofh.it> (permalink)
References	<pzqvT-682-7@gated-at.bofh.it> <pzqvU-682-21@gated-at.bofh.it> <pzVq2-1iX-3@gated-at.bofh.it> <pzY4x-4Z3-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2015-06-11 at 08:58 +0900, Sergey Senozhatsky wrote:
> On (06/10/15 16:59), Dan Streetman wrote:
> > On Tue, Jun 9, 2015 at 8:04 AM, Sergey Senozhatsky
> > <sergey.senozhatsky@gmail.com> wrote:
> > > zpool_destroy_pool() does not tolerate a NULL zpool pointer
> > > argument and performs a NULL-pointer dereference. Although
> > > there is only one zpool_destroy_pool() user (as of 4.1),
> > > still update it to be coherent with the corresponding
> > > destroy() functions of the remainig pool-allocators (slab,
> > > mempool, etc.), which now allow NULL pool-pointers.
> > >
> > > For consistency, tweak zpool_destroy_pool() and NULL-check the
> > > pointer there.
> > >
> > > Proposed by Andrew Morton.
> > >
> > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > > Reported-by: Andrew Morton <akpm@linux-foundation.org>
> > > LKML-reference: https://lkml.org/lkml/2015/6/8/583
> > 
> > Acked-by: Dan Streetman <ddstreet@ieee.org>
> 
> Thanks.
> 
> Shall we ask Joe to add zpool_destroy_pool() to the
> "$func(NULL) is safe and this check is probably not required" list?

[]

Is it really worth it?

There isn't any use of zpool_destroy_pool preceded by an if
There is one and only one use of zpool_destroy_pool.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in  zpool_destroy_pool() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-06-11 02:00 +0200
  Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in  zpool_destroy_pool() Joe Perches <joe@perches.com> - 2015-06-11 02:50 +0200
    Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in  zpool_destroy_pool() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-06-11 03:00 +0200
      Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool() Dan Streetman <ddstreet@ieee.org> - 2015-06-11 03:10 +0200

csiph-web