Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()

From	Dan Streetman <ddstreet@ieee.org>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()
Date	2015-06-11 03:10 +0200
Message-ID	<pzZai-6Ri-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <pzqvU-682-21@gated-at.bofh.it> <pzVq2-1iX-3@gated-at.bofh.it> <pzY4x-4Z3-7@gated-at.bofh.it> <pzYQW-6ff-3@gated-at.bofh.it> <pzZ0C-6qy-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 10, 2015 at 8:59 PM, Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com> wrote:
> On (06/10/15 17:48), Joe Perches wrote:
> [..]
>> > > > For consistency, tweak zpool_destroy_pool() and NULL-check the
>> > > > pointer there.
>> > > >
>> > > > Proposed by Andrew Morton.
>> > > >
>> > > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>> > > > Reported-by: Andrew Morton <akpm@linux-foundation.org>
>> > > > LKML-reference: https://lkml.org/lkml/2015/6/8/583
>> > >
>> > > Acked-by: Dan Streetman <ddstreet@ieee.org>
>> >
>> > Thanks.
>> >
>> > Shall we ask Joe to add zpool_destroy_pool() to the
>> > "$func(NULL) is safe and this check is probably not required" list?
>>
>> []
>>
>> Is it really worth it?
>>
>> There isn't any use of zpool_destroy_pool preceded by an if
>> There is one and only one use of zpool_destroy_pool.
>>
>
> Yes, that's why I asked. I don't think that zpool_destroy_pool()
> will gain any significant amount of users soon (well, who knows),
> so I'm fine with keeping it out of checkpatch checks. Just checked
> your opinion.

I really doubt if zpool will be used by anyone other than zswap anytime soon.

>
>         -ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in  zpool_destroy_pool() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-06-11 02:00 +0200
  Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in  zpool_destroy_pool() Joe Perches <joe@perches.com> - 2015-06-11 02:50 +0200
    Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in  zpool_destroy_pool() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-06-11 03:00 +0200
      Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool() Dan Streetman <ddstreet@ieee.org> - 2015-06-11 03:10 +0200

csiph-web