Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1210416

Re: [RFC] fbdev/nvidia:change reverse_order() macro

From Tomi Valkeinen <tomi.valkeinen@ti.com>
Newsgroups linux.kernel
Subject Re: [RFC] fbdev/nvidia:change reverse_order() macro
Date 2015-08-20 13:10 +0200
Message-ID <pZvTj-337-9@gated-at.bofh.it> (permalink)
References <pZrZo-5EL-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On 20/08/15 09:52, yalin wang wrote:
> This change reverse_order() to swab32(bitrev32()), so that
> it can have better performance on some platforms.
> 
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> ---
>  drivers/video/fbdev/nvidia/nv_accel.c |  4 ++--
>  drivers/video/fbdev/nvidia/nv_local.h | 13 ++++---------
>  2 files changed, 6 insertions(+), 11 deletions(-)

I have more or less the same comments here as for the riva patch, except
in this one I'd change the macro to an static inline function.

 Tomi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[RFC] fbdev/nvidia:change reverse_order() macro yalin wang <yalin.wang2010@gmail.com> - 2015-08-20 09:00 +0200
  Re: [RFC] fbdev/nvidia:change reverse_order() macro Tomi Valkeinen <tomi.valkeinen@ti.com> - 2015-08-20 13:10 +0200

csiph-web