Re: [RFC] fbdev/nvidia:change reverse_order() macro

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Tomi Valkeinen <tomi.valkeinen@ti.com>
Newsgroups	linux.kernel
Subject	Re: [RFC] fbdev/nvidia:change reverse_order() macro
Date	Thu, 20 Aug 2015 13:10:01 +0200
Message-ID	<pZvTj-337-9@gated-at.bofh.it> (permalink)
References	<pZrZo-5EL-17@gated-at.bofh.it>
X-Original-To	yalin wang <yalin.wang2010@gmail.com>, <adaplas@gmail.com>, <plagnioj@jcrosoft.com>, <linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5icb3k99BN7rEN7fJhMseB7EWKAWfnDqr"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	50
Organization	linux.* mail to news gateway
X-Original-Date	Thu, 20 Aug 2015 14:04:09 +0300
X-Original-Message-ID	<55D5B429.8040605@ti.com>
X-Original-References	<1440053547-24193-1-git-send-email-yalin.wang2010@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1210416

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On 20/08/15 09:52, yalin wang wrote:
> This change reverse_order() to swab32(bitrev32()), so that
> it can have better performance on some platforms.
> 
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> ---
>  drivers/video/fbdev/nvidia/nv_accel.c |  4 ++--
>  drivers/video/fbdev/nvidia/nv_local.h | 13 ++++---------
>  2 files changed, 6 insertions(+), 11 deletions(-)

I have more or less the same comments here as for the riva patch, except
in this one I'd change the macro to an static inline function.

 Tomi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC] fbdev/nvidia:change reverse_order() macro yalin wang <yalin.wang2010@gmail.com> - 2015-08-20 09:00 +0200
  Re: [RFC] fbdev/nvidia:change reverse_order() macro Tomi Valkeinen <tomi.valkeinen@ti.com> - 2015-08-20 13:10 +0200

csiph-web