Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1209821
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/6] mfd: cros_ec: Remove CROS_EC_PROTO dependency for SPI and I2C drivers |
| Date | 2015-08-19 15:00 +0200 |
| Message-ID | <pZb8e-6mr-1@gated-at.bofh.it> (permalink) |
| References | <pZ9J7-4sk-3@gated-at.bofh.it> <pZ9J8-4sk-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 19 Aug 2015, Javier Martinez Canillas wrote: > The ChromeOS EC SPI and I2C transport drivers depends on CROS_EC_PROTO > but MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends > on is bad practice as it may lead to circular Kconfig dependencies. > > Since these drivers already depend on MFD_CROS_EC and that config option > already selects CROS_EC_PROTO, there is no need to make them explicitly > depend on CROS_EC_PROTO since that dependency is already met. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > > drivers/mfd/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index feebc750aadf..99d63675f073 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -106,7 +106,7 @@ config MFD_CROS_EC > > config MFD_CROS_EC_I2C > tristate "ChromeOS Embedded Controller (I2C)" > - depends on MFD_CROS_EC && CROS_EC_PROTO && I2C > + depends on MFD_CROS_EC && I2C > > help > If you say Y here, you get support for talking to the ChromeOS > @@ -116,7 +116,7 @@ config MFD_CROS_EC_I2C > > config MFD_CROS_EC_SPI > tristate "ChromeOS Embedded Controller (SPI)" > - depends on MFD_CROS_EC && CROS_EC_PROTO && SPI > + depends on MFD_CROS_EC && SPI > > ---help--- > If you say Y here, you get support for talking to the ChromeOS EC -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 4/6] mfd: cros_ec: Remove CROS_EC_PROTO dependency for SPI and I2C drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-19 13:30 +0200 Re: [PATCH 4/6] mfd: cros_ec: Remove CROS_EC_PROTO dependency for SPI and I2C drivers Lee Jones <lee.jones@linaro.org> - 2015-08-19 15:00 +0200
csiph-web