Groups > linux.kernel > #1209821

Re: [PATCH 4/6] mfd: cros_ec: Remove CROS_EC_PROTO dependency for SPI and I2C drivers

Path	csiph.com!xmission!news.glorb.com!bofh.it!news.nic.it!robomod
From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/6] mfd: cros_ec: Remove CROS_EC_PROTO dependency for SPI and I2C drivers
Date	Wed, 19 Aug 2015 15:00:02 +0200
Message-ID	<pZb8e-6mr-1@gated-at.bofh.it> (permalink)
References	<pZ9J7-4sk-3@gated-at.bofh.it> <pZ9J8-4sk-13@gated-at.bofh.it>
X-Original-To	Javier Martinez Canillas <javier@osg.samsung.com>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=k/SuKVfPcB9tDP7w3+R0OztpEL0eazTZTgJgieMduRk=; b=Jz8N+h1gOdxgnYPbZTVCK7wNFLty847Piz5MQNIYuXKMepLs68JPF86XEoEr9NC1SW WDniZl/JdNvUB0FY0VIZYNTWI6oyHwl04icWIX0b3z2M5tFMUKoHDAor/EGrHHGCqFIp +9iTtbFVpz1qN4eh9snE/c0Scnt+cNHnZjkavbsa9bcEL2sbhqNfVNcYWHtgURctQoxM 64jHitT3u1XH2YaJOtn+S9vUh4tb/Mm8V5csLUO738R8w5hgQBP/q3vF9oWWX2KvedOM gMhPz+4479JnYBy5A4g0kToNelpEZgh7RPu3GUeQfHfyWXDBeKGa6EX//iYZug6n/gdA 2Q+g==
X-Gm-Message-State	ALoCoQnt4DvXMHYxjuoZ8FaKINpli5GYFQiff1VEE1HycCD83wxr6BCjyEyLEVeqyjRBlhOGy/5N
X-Received	by 10.180.86.138 with SMTP id p10mr2952084wiz.39.1439989171187; Wed, 19 Aug 2015 05:59:31 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
Content-Transfer-Encoding	8bit
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	51
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Gwendal Grignou <gwendal@chromium.org>, Doug Anderson <dianders@chromium.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Wolfram Sang <wsa@the-dreams.de>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Olof Johansson <olof@lixom.net>
X-Original-Date	Wed, 19 Aug 2015 13:59:27 +0100
X-Original-Message-ID	<20150819125927.GJ6180@x1>
X-Original-References	<1439983198-4696-1-git-send-email-javier@osg.samsung.com> <1439983198-4696-5-git-send-email-javier@osg.samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1209821

Show key headers only | View raw

On Wed, 19 Aug 2015, Javier Martinez Canillas wrote:

> The ChromeOS EC SPI and I2C transport drivers depends on CROS_EC_PROTO
> but MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends
> on is bad practice as it may lead to circular Kconfig dependencies.
> 
> Since these drivers already depend on MFD_CROS_EC and that config option
> already selects CROS_EC_PROTO, there is no need to make them explicitly
> depend on CROS_EC_PROTO since that dependency is already met.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  drivers/mfd/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index feebc750aadf..99d63675f073 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -106,7 +106,7 @@ config MFD_CROS_EC
>  
>  config MFD_CROS_EC_I2C
>  	tristate "ChromeOS Embedded Controller (I2C)"
> -	depends on MFD_CROS_EC && CROS_EC_PROTO && I2C
> +	depends on MFD_CROS_EC && I2C
>  
>  	help
>  	  If you say Y here, you get support for talking to the ChromeOS
> @@ -116,7 +116,7 @@ config MFD_CROS_EC_I2C
>  
>  config MFD_CROS_EC_SPI
>  	tristate "ChromeOS Embedded Controller (SPI)"
> -	depends on MFD_CROS_EC && CROS_EC_PROTO && SPI
> +	depends on MFD_CROS_EC && SPI
>  
>  	---help---
>  	  If you say Y here, you get support for talking to the ChromeOS EC

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/6] mfd: cros_ec: Remove CROS_EC_PROTO dependency for SPI and I2C drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-19 13:30 +0200
  Re: [PATCH 4/6] mfd: cros_ec: Remove CROS_EC_PROTO dependency for  SPI and I2C drivers Lee Jones <lee.jones@linaro.org> - 2015-08-19 15:00 +0200

csiph-web