Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209283

Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

Show all headers | View raw

Hi Yaniv,

2015-08-16 19:14 GMT+09:00 Yaniv Gardi <ygardi@codeaurora.org>:
> @@ -708,17 +713,18 @@ static inline u32 ufshcd_vops_get_ufs_hci_version(struct ufs_hba *hba)
>         return ufshcd_readl(hba, REG_UFS_VERSION);
>  }
>
> -static inline void ufshcd_vops_clk_scale_notify(struct ufs_hba *hba)
> +static inline int ufshcd_vops_clk_scale_notify(struct ufs_hba *hba,
> +                                               bool up, bool status)
>  {
>         if (hba->vops && hba->vops->clk_scale_notify)
> -               return hba->vops->clk_scale_notify(hba);
> +               return hba->vops->clk_scale_notify(hba, up, status);
> +       return 0;
>  }

The third argument of clk_scale_notify() vops is PRE_CHANGE or
POST_CHANGE.  So should it also be converted from bool to enum
ufs_notify_change_status like other vops does?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1 0/8] Fix error message and present UFS variant Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-16 12:20 +0200
  [PATCH v1 5/8] scsi: ufs: creates wrapper functions for vops Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-16 12:20 +0200
    Re: [PATCH v1 5/8] scsi: ufs: creates wrapper functions for vops Akinobu Mita <akinobu.mita@gmail.com> - 2015-08-19 14:20 +0200
  [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-16 12:20 +0200
    Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and  power optimizations Akinobu Mita <akinobu.mita@gmail.com> - 2015-08-18 16:30 +0200
    Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and  power optimizations Akinobu Mita <akinobu.mita@gmail.com> - 2015-08-19 14:20 +0200
  [PATCH v1 4/8] add ufshcd_get_variant ufshcd_set_variant Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-16 12:20 +0200

csiph-web