Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209110

Re: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver

Show all headers | View raw

Hello Krzysztof,

On 08/18/2015 09:57 AM, Krzysztof Kozlowski wrote:
> On 18.08.2015 16:01, Javier Martinez Canillas wrote:
>> The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config
>> symbol because the driver uses some communication helper functions in
>> drivers/platform/chrome/cros_ec_proto.c but other drivers depends on
>> CROS_EC_PROTO instead. Mixing select and depends can lead to circular
>> Kconfig dependencies so the MFD_CROS_EC select should be changed to a
>> depends on CROS_EC_PROTO instead.
>>
>> But doing so will break git bisect-ability since MFD_CROS_EC will not
>> be enabled anymore unless the default configs first explicitly enable
>> the CROS_EC_PROTO dependency.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>  arch/arm/configs/exynos_defconfig | 1 +
>>  1 file changed, 1 insertion(+)
> 
> I saw the discussion about circular dependency but I wasn't following
> it. Currently the CROS_EC_PROTO is not user-selectable. How can you
> depend on it? How can be enabled on different configs (customized by user)?
> 
> Maybe the questions are answered by code in different patches?

Yes, that's why I posted "[PATCH] platform/chrome: Make CROS_EC_PROTO
a user selectable option" [0].

I posted as separate patches because there isn't a dependency between
them and once all the defconfig patches and the patch to make the
CROS_EC_PROTO symbol user selectable lands, I'll post the patch to
change select for depends on to avoid a regression.

Maybe I should had posted as a series (or at least cc all the people
in all the patches) to not left these questions unanswered...

> 
> Best regards,
> Krzysztof
> 
> 

[0]: https://lkml.org/lkml/2015/8/18/61

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-18 09:10 +0200
  Re: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS  EC mfd driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-18 10:00 +0200
    Re: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS  EC mfd driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-18 10:10 +0200
      Re: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS  EC mfd driver Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-18 10:20 +0200
    Re: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS  EC mfd driver Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-18 10:10 +0200

csiph-web