Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209081

[PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver

Show all headers | View raw

The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config
symbol because the driver uses some communication helper functions in
drivers/platform/chrome/cros_ec_proto.c but other drivers depends on
CROS_EC_PROTO instead. Mixing select and depends can lead to circular
Kconfig dependencies so the MFD_CROS_EC select should be changed to a
depends on CROS_EC_PROTO instead.

But doing so will break git bisect-ability since MFD_CROS_EC will not
be enabled anymore unless the default configs first explicitly enable
the CROS_EC_PROTO dependency.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
 arch/arm/configs/exynos_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 1ff2bfa2e183..537391ea37ac 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -177,6 +177,7 @@ CONFIG_DMADEVICES=y
 CONFIG_PL330_DMA=y
 CONFIG_CHROME_PLATFORMS=y
 CONFIG_CROS_EC_CHARDEV=y
+CONFIG_CROS_EC_PROTO=y
 CONFIG_COMMON_CLK_MAX77686=y
 CONFIG_COMMON_CLK_MAX77802=y
 CONFIG_COMMON_CLK_S2MPS11=y
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-18 09:10 +0200
  Re: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS  EC mfd driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-18 10:00 +0200
    Re: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS  EC mfd driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-18 10:10 +0200
      Re: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS  EC mfd driver Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-18 10:20 +0200
    Re: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS  EC mfd driver Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-18 10:10 +0200

csiph-web