Groups > linux.kernel > #1204764

Re: [PATCH net] netconsole: Check for carrier before calling netpoll_send_udp()

From	Jonathan Maxwell <jmaxwell37@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] netconsole: Check for carrier before calling netpoll_send_udp()
Date	2015-08-11 08:00 +0200
Message-ID	<pWaLn-4v5-3@gated-at.bofh.it> (permalink)
References	<pW6HL-75p-1@gated-at.bofh.it> <pW9mi-2Cq-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> What if the carrier check passes, and then the chip reset starts on
> another cpu?  You'll have the same problem.

Okay, let me see if I can come up with a better way to mitigate this.

On Tue, Aug 11, 2015 at 2:22 PM, David Miller <davem@davemloft.net> wrote:
> From: Jon Maxwell <jmaxwell37@gmail.com>
> Date: Tue, 11 Aug 2015 11:32:26 +1000
>
>> We have seen a few crashes recently where a NIC is getting
>> reset for some reason and then the driver or another module calls
>> printk() which invokes netconsole. Netconsole then calls the
>> adapter specific poll routine via netpoll which crashes because
>> the adapter is resetting and its structures are being reinitialized.
>
> This isn't a fix.
>
> What if the carrier check passes, and then the chip reset starts on
> another cpu?  You'll have the same problem.
>
> I'm not applying this, sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH net] netconsole: Check for carrier before calling netpoll_send_udp() Jon Maxwell <jmaxwell37@gmail.com> - 2015-08-11 03:40 +0200
  Re: [PATCH net] netconsole: Check for carrier before calling  netpoll_send_udp() David Miller <davem@davemloft.net> - 2015-08-11 06:30 +0200
    Re: [PATCH net] netconsole: Check for carrier before calling netpoll_send_udp() Jonathan Maxwell <jmaxwell37@gmail.com> - 2015-08-11 08:00 +0200
      Re: [PATCH net] netconsole: Check for carrier before calling  netpoll_send_udp() David Miller <davem@davemloft.net> - 2015-08-11 19:30 +0200
        Re: [PATCH net] netconsole: Check for carrier before calling netpoll_send_udp() Jonathan Maxwell <jmaxwell37@gmail.com> - 2015-08-12 05:10 +0200

csiph-web