Groups > linux.kernel > #1205317

Re: [PATCH net] netconsole: Check for carrier before calling netpoll_send_udp()

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] netconsole: Check for carrier before calling netpoll_send_udp()
Date	2015-08-11 19:30 +0200
Message-ID	<pWlx8-3nb-37@gated-at.bofh.it> (permalink)
References	<pW6HL-75p-1@gated-at.bofh.it> <pW9mi-2Cq-1@gated-at.bofh.it> <pWaLn-4v5-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Jonathan Maxwell <jmaxwell37@gmail.com>
Date: Tue, 11 Aug 2015 15:53:18 +1000

>> What if the carrier check passes, and then the chip reset starts on
>> another cpu?  You'll have the same problem.
> 
> Okay, let me see if I can come up with a better way to mitigate this.

I personally think that drivers need to synchronize such things
internally.  They are the only entity which knows when it's "OK"
to do whatever the netpoll method does, and they are also the only
entity which can properly synchronize such checks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH net] netconsole: Check for carrier before calling netpoll_send_udp() Jon Maxwell <jmaxwell37@gmail.com> - 2015-08-11 03:40 +0200
  Re: [PATCH net] netconsole: Check for carrier before calling  netpoll_send_udp() David Miller <davem@davemloft.net> - 2015-08-11 06:30 +0200
    Re: [PATCH net] netconsole: Check for carrier before calling netpoll_send_udp() Jonathan Maxwell <jmaxwell37@gmail.com> - 2015-08-11 08:00 +0200
      Re: [PATCH net] netconsole: Check for carrier before calling  netpoll_send_udp() David Miller <davem@davemloft.net> - 2015-08-11 19:30 +0200
        Re: [PATCH net] netconsole: Check for carrier before calling netpoll_send_udp() Jonathan Maxwell <jmaxwell37@gmail.com> - 2015-08-12 05:10 +0200

csiph-web