Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1201802

Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode

Show all headers | View raw

Hi Jingoo,

在 2015/8/6 22:19, Jingoo Han 写道:
> On Thursday, August 06, 2015 11:07 PM, Yakir Yang wrote:
>> In order to move exynos dp code to bridge directory,
>> we need to convert driver drm bridge mode first. As
>> dp driver already have a ptn3460 bridge, so we need
>> to move ptn bridge to the next bridge of dp bridge.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
>>   drivers/gpu/drm/exynos/exynos_dp_core.c | 196 ++++++++++++++++++++------------
>>   drivers/gpu/drm/exynos/exynos_dp_core.h |   2 +
>>   2 files changed, 126 insertions(+), 72 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
>> index a8097a4..aa99e23 100644
>> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
>> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
>> @@ -3,6 +3,7 @@
>>    *
>>    * Copyright (C) 2012 Samsung Electronics Co., Ltd.
>>    * Author: Jingoo Han <jg1.han@samsung.com>
>> + *         Yakir Yang <ykk@rock-chips.com>
> Please don't add this.
> You just fixed some parts of this code. I don't find the reason
> why you have to be added to author for this file.
> If you want the title for an author, please send the patch
> for a new IP, instead of modifying the exiting codes.

Okay, thanks for your remind ;)

>>   [...]
>>   MODULE_AUTHOR("Jingoo Han <jg1.han@samsung.com>");
>> +MODULE_AUTHOR("Yakir Yang <ykk@rock-chips.com>");
> The same as above.

Done
>>   MODULE_DESCRIPTION("Samsung SoC DP Driver");
>>   MODULE_LICENSE("GPL v2");
>> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.h b/drivers/gpu/drm/exynos/exynos_dp_core.h
>> index c321ad5..f2584b8 100644
>> --- a/drivers/gpu/drm/exynos/exynos_dp_core.h
>> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.h
>> @@ -3,6 +3,7 @@
>>    *
>>    * Copyright (C) 2012 Samsung Electronics Co., Ltd.
>>    * Author: Jingoo Han <jg1.han@samsung.com>
>> + *         Yakir Yang <ykk@rock-chips.com>
> The same as above.
> Here, you just added 1 line. If we add someone to author
> in this way, a lot of people should be added to author.

Done

- Yakir
> Best regards,
> Jingoo Han
>
>
>
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/8] Add Analogix Core Display Port Driver Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:00 +0200
  [RFC PATCH 1/8] drm: exynos/dp: fix code style Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:00 +0200
  [RFC PATCH 1/8] drm: exynos/dp: fix code style Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:10 +0200
    Re: [RFC PATCH 1/8] drm: exynos/dp: fix code style Joe Perches <joe@perches.com> - 2015-08-06 17:10 +0200
      Re: [RFC PATCH 1/8] drm: exynos/dp: fix code style Yakir Yang <ykk@rock-chips.com> - 2015-08-06 17:30 +0200
  [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:10 +0200
    Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode "Jingoo Han" <jingoohan1@gmail.com> - 2015-08-06 16:30 +0200
      Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:30 +0200
        Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode Daniel Vetter <daniel@ffwll.ch> - 2015-08-07 13:30 +0200
          Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode Yakir Yang <ykk@rock-chips.com> - 2015-08-07 15:20 +0200
  [RFC PATCH 6/8] drm: bridge: analogix_dp: add some rk3288 special registers setting Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:30 +0200
  [RFC PATCH 7/8] drm: bridge: analogix_dp: try force hpd after plug in lookup failed Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:30 +0200
  [RFC PATCH 4/8] drm: rockchip/dp: add rockchip platform dp driver Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:30 +0200
  [RFC PATCH 5/8] drm: bridge/analogix_dp: add platform device type support Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:30 +0200
  [RFC PATCH 8/8] drm: bridge/analogix_dp: expand the delay time for hpd detect Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:40 +0200
  Re: [RFC PATCH 3/8] drm: bridge: analogix_dp: split exynos dp driver to bridge dir "Jingoo Han" <jingoohan1@gmail.com> - 2015-08-06 16:40 +0200
    Re: [RFC PATCH 3/8] drm: bridge: analogix_dp: split exynos dp driver  to bridge dir Yakir Yang <ykk@rock-chips.com> - 2015-08-06 17:00 +0200
  [RFC PATCH 3/8] drm: bridge: analogix_dp: split exynos dp driver to bridge dir Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:40 +0200
  Re: [RFC PATCH 0/8] Add Analogix Core Display Port Driver "Jingoo Han" <jingoohan1@gmail.com> - 2015-08-06 16:50 +0200
    Re: [RFC PATCH 0/8] Add Analogix Core Display Port Driver Yakir Yang <ykk@rock-chips.com> - 2015-08-06 17:10 +0200

csiph-web