Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1201830
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 1/8] drm: exynos/dp: fix code style |
| Date | 2015-08-06 17:10 +0200 |
| Message-ID | <pUuXT-4cV-7@gated-at.bofh.it> (permalink) |
| References | <pUtSa-2in-11@gated-at.bofh.it> <pUu1Q-2J4-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 2015-08-06 at 09:04 -0500, Yakir Yang wrote: > make checkpatch.pl script happy That should not be the primary reason to submit a patch. Making it easier for human code reader to understand what the code does should be though. > diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c [] > @@ -123,10 +123,11 @@ static int exynos_dp_read_edid(struct exynos_dp_device *dp) > dev_dbg(dp->dev, "EDID data includes a single extension!\n"); > > /* Read EDID data */ > - retval = exynos_dp_read_bytes_from_i2c(dp, I2C_EDID_DEVICE_ADDR, > - EDID_HEADER_PATTERN, > - EDID_BLOCK_LENGTH, > - &edid[EDID_HEADER_PATTERN]); > + retval = > + exynos_dp_read_bytes_from_i2c(dp, I2C_EDID_DEVICE_ADDR, > + EDID_HEADER_PATTERN, > + EDID_BLOCK_LENGTH, > + &edid[EDID_HEADER_PATTERN]); This is a relatively uncommon style. Because the code uses relatively long variable and function names as well as longish macro #defines, prefer to ignore the 80 column limit. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH 0/8] Add Analogix Core Display Port Driver Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:00 +0200
[RFC PATCH 1/8] drm: exynos/dp: fix code style Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:00 +0200
[RFC PATCH 1/8] drm: exynos/dp: fix code style Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:10 +0200
Re: [RFC PATCH 1/8] drm: exynos/dp: fix code style Joe Perches <joe@perches.com> - 2015-08-06 17:10 +0200
Re: [RFC PATCH 1/8] drm: exynos/dp: fix code style Yakir Yang <ykk@rock-chips.com> - 2015-08-06 17:30 +0200
[RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:10 +0200
Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode "Jingoo Han" <jingoohan1@gmail.com> - 2015-08-06 16:30 +0200
Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:30 +0200
Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode Daniel Vetter <daniel@ffwll.ch> - 2015-08-07 13:30 +0200
Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode Yakir Yang <ykk@rock-chips.com> - 2015-08-07 15:20 +0200
[RFC PATCH 6/8] drm: bridge: analogix_dp: add some rk3288 special registers setting Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:30 +0200
[RFC PATCH 7/8] drm: bridge: analogix_dp: try force hpd after plug in lookup failed Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:30 +0200
[RFC PATCH 4/8] drm: rockchip/dp: add rockchip platform dp driver Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:30 +0200
[RFC PATCH 5/8] drm: bridge/analogix_dp: add platform device type support Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:30 +0200
[RFC PATCH 8/8] drm: bridge/analogix_dp: expand the delay time for hpd detect Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:40 +0200
Re: [RFC PATCH 3/8] drm: bridge: analogix_dp: split exynos dp driver to bridge dir "Jingoo Han" <jingoohan1@gmail.com> - 2015-08-06 16:40 +0200
Re: [RFC PATCH 3/8] drm: bridge: analogix_dp: split exynos dp driver to bridge dir Yakir Yang <ykk@rock-chips.com> - 2015-08-06 17:00 +0200
[RFC PATCH 3/8] drm: bridge: analogix_dp: split exynos dp driver to bridge dir Yakir Yang <ykk@rock-chips.com> - 2015-08-06 16:40 +0200
Re: [RFC PATCH 0/8] Add Analogix Core Display Port Driver "Jingoo Han" <jingoohan1@gmail.com> - 2015-08-06 16:50 +0200
Re: [RFC PATCH 0/8] Add Analogix Core Display Port Driver Yakir Yang <ykk@rock-chips.com> - 2015-08-06 17:10 +0200
csiph-web