Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1200314

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

Show all headers | View raw

On 08/04/2015 02:12 PM, Julien Grall wrote:
>   
>   /*
>    * We detect special mappings in one of two ways:
> @@ -217,9 +232,13 @@ static inline unsigned long bfn_to_local_pfn(unsigned long mfn)
>   
>   /* VIRT <-> MACHINE conversion */
>   #define virt_to_machine(v)	(phys_to_machine(XPADDR(__pa(v))))
> -#define virt_to_pfn(v)          (PFN_DOWN(__pa(v)))
>   #define virt_to_mfn(v)		(pfn_to_mfn(virt_to_pfn(v)))
>   #define mfn_to_virt(m)		(__va(mfn_to_pfn(m) << PAGE_SHIFT))
> +#define virt_to_pfn(v)          (PFN_DOWN(__pa(v)))

This looks like unnecessary change.


> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> index 09dc447..25e3cce 100644
> --- a/drivers/video/fbdev/xen-fbfront.c
> +++ b/drivers/video/fbdev/xen-fbfront.c
> @@ -539,7 +539,7 @@ static int xenfb_remove(struct xenbus_device *dev)
>   
>   static unsigned long vmalloc_to_mfn(void *address)
>   {
> -	return pfn_to_mfn(vmalloc_to_pfn(address));
> +	return pfn_to_gfn(vmalloc_to_pfn(address));
>   }

Are you sure? This will return vmalloc_to_pfn(address)).


-boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/8] Use correctly the Xen memory terminologies in Linux Julien Grall <julien.grall@citrix.com> - 2015-08-04 20:20 +0200
  [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies Julien Grall <julien.grall@citrix.com> - 2015-08-04 20:20 +0200
    Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-08-05 01:30 +0200
      Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory  terminologies Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-08-05 12:10 +0200
      Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies Julien Grall <julien.grall@citrix.com> - 2015-08-05 13:00 +0200
        Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-08-05 14:30 +0200
          Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory  terminologies Julien Grall <julien.grall@citrix.com> - 2015-08-05 14:40 +0200
            Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory  terminologies Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-08-05 14:50 +0200
    Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory  terminologies Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-08-05 12:20 +0200
      Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory  terminologies Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-08-05 19:00 +0200
    Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory  terminologies Wei Liu <wei.liu2@citrix.com> - 2015-08-05 19:10 +0200
    Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory  terminologies Julien Grall <julien.grall@citrix.com> - 2015-08-06 13:10 +0200
      Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory  terminologies Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-08-06 13:10 +0200
        Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory  terminologies Julien Grall <julien.grall@citrix.com> - 2015-08-06 13:20 +0200
          Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory  terminologies Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-08-06 16:30 +0200

csiph-web