Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1200315

Re: [PATCH] serial: don't announce CIR serial ports

Show all headers | View raw

Hi Peter,

Thanks for looking into it.

On 04.08.2015 03:46, Peter Hurley wrote:
> Hi Maciej,
> 
> On 08/02/2015 05:09 PM, Maciej S. Szmigiero wrote:
>> CIR type serial ports aren't real serial ports.
>> This is just a way to prevent legacy serial driver
>> from probing and eventually binding some resources
>> so don't announce them like normal serial ports.
> 
> I'd like to keep some form of reporting so that we know the
> port was properly probed; what about extending uart_report_port()
> to including CIR + disabled status?

Currently the printed message looks like this:
"00:01: ttyS2 at I/O 0x3e8 (irq = 7, base_baud = 115200) is a CIR port".

I think it would be best to skip a device file name in this case,
since this is how user sees (and uses) a real serial port.
The message would be then:
"00:01 at I/O 0x3e8 (irq = 7, base_baud = 115200) is a CIR port".

The dev name will always be present since the only current
"source" of CIR ports is PNP 8250 driver which sets 
dev pointer uncondtionally.

> Secondly, good catch! Because we should not be trying to
> register a console on this port, nor driving modem signals.
> 
> So maybe an early exit after uart_report_port?

All right, I will resubmit updated patch tomorrow.

> Regards,
> Peter Hurley

Best regards,
Maciej Szmigiero
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] serial: don't announce CIR serial ports "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2015-08-02 23:20 +0200
  Re: [PATCH] serial: don't announce CIR serial ports Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-08-04 01:50 +0200
    Re: [PATCH] serial: don't announce CIR serial ports "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2015-08-04 02:50 +0200
  Re: [PATCH] serial: don't announce CIR serial ports Peter Hurley <peter@hurleysoftware.com> - 2015-08-04 03:50 +0200
    Re: [PATCH] serial: don't announce CIR serial ports "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2015-08-05 01:30 +0200
      Re: [PATCH] serial: don't announce CIR serial ports Peter Hurley <peter@hurleysoftware.com> - 2015-08-05 04:10 +0200
        Re: [PATCH] serial: don't announce CIR serial ports "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2015-08-05 14:40 +0200

csiph-web