Groups > linux.kernel > #1198415

Re: [PATCH v2 5/6] power: bq27xxx_battery: Add support for additional bq27xxx family devices

From	"Andrew F. Davis" <afd@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 5/6] power: bq27xxx_battery: Add support for additional bq27xxx family devices
Date	2015-08-02 19:50 +0200
Message-ID	<pT5yy-2Cb-29@gated-at.bofh.it> (permalink)
References	<pRiTg-1Zj-17@gated-at.bofh.it> <pRj2W-2aU-17@gated-at.bofh.it> <pSW2f-5CG-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/02/2015 02:38 AM, Pavel Machek wrote:
>
>> +#define INVALID_REG_ADDR	0xff
>
>> +static u8 bq27000_regs[] = {
>> +	0x00,	/* CONTROL	*/
>> +	0x06,	/* TEMP		*/
>> +	0xff,	/* INT TEMP - NA*/
>
> I'd use the INVALID_REG_ADDR macro here.. Makes it more clear what is
> going on (and you may change it to -1 in future, for example).
>

That works, I'll do that.

Thanks,
-- 
Andrew F. Davis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 5/6] power: bq27xxx_battery: Add support for additional  bq27xxx family devices "Andrew F. Davis" <afd@ti.com> - 2015-08-02 19:50 +0200

csiph-web