Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1198415
| Path | csiph.com!optima2.xanadu-bbs.net!xanadu-bbs.net!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | "Andrew F. Davis" <afd@ti.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 5/6] power: bq27xxx_battery: Add support for additional bq27xxx family devices |
| Date | Sun, 02 Aug 2015 19:50:02 +0200 |
| Message-ID | <pT5yy-2Cb-29@gated-at.bofh.it> (permalink) |
| References | <pRiTg-1Zj-17@gated-at.bofh.it> <pRj2W-2aU-17@gated-at.bofh.it> <pSW2f-5CG-25@gated-at.bofh.it> |
| X-Original-To | Pavel Machek <pavel@ucw.cz> |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset="windows-1252"; format=flowed |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 23 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Pali Rohár <pali.rohar@gmail.com>, Sebastian Reichel <sre@kernel.org>, Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>, David Woodhouse <dwmw2@infradead.org>, Dan Murphy <dmurphy@ti.com>, <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org> |
| X-Original-Date | Sun, 2 Aug 2015 12:43:17 -0500 |
| X-Original-Message-ID | <55BE56B5.6040608@ti.com> |
| X-Original-References | <1438112353-19704-1-git-send-email-afd@ti.com> <1438112353-19704-6-git-send-email-afd@ti.com> <20150802073853.GD3720@amd> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1198415 |
Show key headers only | View raw
On 08/02/2015 02:38 AM, Pavel Machek wrote:
>
>> +#define INVALID_REG_ADDR 0xff
>
>> +static u8 bq27000_regs[] = {
>> + 0x00, /* CONTROL */
>> + 0x06, /* TEMP */
>> + 0xff, /* INT TEMP - NA*/
>
> I'd use the INVALID_REG_ADDR macro here.. Makes it more clear what is
> going on (and you may change it to -1 in future, for example).
>
That works, I'll do that.
Thanks,
--
Andrew F. Davis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH v2 5/6] power: bq27xxx_battery: Add support for additional bq27xxx family devices "Andrew F. Davis" <afd@ti.com> - 2015-08-02 19:50 +0200
csiph-web