Re: kdbus: to merge or not to merge?

From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: kdbus: to merge or not to merge?
Date	2015-07-09 10:50 +0200
Message-ID	<pKfGP-6mA-13@gated-at.bofh.it> (permalink)
References	<pEpzc-2uw-1@gated-at.bofh.it> <pEqbT-3d4-1@gated-at.bofh.it> <pJY3h-3ql-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 8, 2015 at 3:54 PM, Pavel Machek <pavel@ucw.cz> wrote:
> Apparently, new tools are needed in the community, as normal review
> comments did not stop drivers/android/binder.c merge.
>
> For example binder_transaction does not exactly look like a kernel
> code, "TODO: fput" does not really invoke confidence, and ammount of
> BUG_ON()s is quite amazing...

Amazingly, checkpatch (without --strict) only complains about long lines.

Seems like the test for "BUG" is (and always has been) commented out...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: kdbus: to merge or not to merge? Geert Uytterhoeven <geert@linux-m68k.org> - 2015-07-09 10:50 +0200
  Re: kdbus: to merge or not to merge? Pavel Machek <pavel@ucw.cz> - 2015-07-09 13:40 +0200

csiph-web