Re: kdbus: to merge or not to merge?

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: kdbus: to merge or not to merge?
Date	Thu, 09 Jul 2015 10:50:03 +0200
Message-ID	<pKfGP-6mA-13@gated-at.bofh.it> (permalink)
References	<pEpzc-2uw-1@gated-at.bofh.it> <pEqbT-3d4-1@gated-at.bofh.it> <pJY3h-3ql-33@gated-at.bofh.it>
X-Original-To	Pavel Machek <pavel@ucw.cz>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=QsRE+ENCghQVuY4CCo17IVbfc5oEaei04NxkV+BDJ4A=; b=hUiyEzO2nU2s/9nSdMKQtoJTrDMjLp0Xz1/LKFMb9z7CTzK+LTj7vYWgEq8WUJo6Kh Edmx9RKziVawIU1VQv0fIsdXD6vuIIAN/PtCZ7Pzu152dzsRJJzCM0QCHb3tWTzVxNaK Wol44KlbttW8cJfyIEFQNnAWHgM16fdhBMGp9Us9I5l/9+MdevECwfFzk7iGoINmlver 6hDBFfaJyMtRXk/TgWEuPyisqTmVUBuGZ/poM3Dd1/MF7WcPCzsgvqzaBMGjHvf19eDI OV/c8YKTUIzzTaZapBu7mMuBCRwd+d+Rbm6qCQopavooGTglI1x1VGVeCRT5zaNiRTNi QKmw==
MIME-Version	1.0
X-Received	by 10.202.224.87 with SMTP id x84mr13207170oig.18.1436431198388; Thu, 09 Jul 2015 01:39:58 -0700 (PDT)
X-Google-Sender-Auth	37iwvHn3566pHb-yoZV7BJPl7uQ
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
Organization	linux.* mail to news gateway
X-Original-Cc	Greg KH <gregkh@linuxfoundation.org>, Andy Lutomirski <luto@amacapital.net>, Linus Torvalds <torvalds@linux-foundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, David Herrmann <dh.herrmann@gmail.com>, Djalal Harouni <tixxdz@opendz.org>, Havoc Pennington <havoc.pennington@gmail.com>, "Eric W. Biederman" <ebiederm@xmission.com>, One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>, Tom Gundersen <teg@jklm.no>, Daniel Mack <daniel@zonque.org>
X-Original-Date	Thu, 9 Jul 2015 10:39:58 +0200
X-Original-Message-ID	<CAMuHMdVMEYeW1e28BTGYPT7mKOSaZTScE_-tXt6_rAEvKDsGPQ@mail.gmail.com>
X-Original-References	<CALCETrW5sdcwM4zoX7BQdf+a2fWgQhd6rPDg8br0FU7Xy-2ZhQ@mail.gmail.com> <20150623064140.GA18300@kroah.com> <20150708135402.GA13432@amd>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1180556

Show key headers only | View raw

On Wed, Jul 8, 2015 at 3:54 PM, Pavel Machek <pavel@ucw.cz> wrote:
> Apparently, new tools are needed in the community, as normal review
> comments did not stop drivers/android/binder.c merge.
>
> For example binder_transaction does not exactly look like a kernel
> code, "TODO: fput" does not really invoke confidence, and ammount of
> BUG_ON()s is quite amazing...

Amazingly, checkpatch (without --strict) only complains about long lines.

Seems like the test for "BUG" is (and always has been) commented out...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: kdbus: to merge or not to merge? Geert Uytterhoeven <geert@linux-m68k.org> - 2015-07-09 10:50 +0200
  Re: kdbus: to merge or not to merge? Pavel Machek <pavel@ucw.cz> - 2015-07-09 13:40 +0200

csiph-web