Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU
Date	2015-07-07 18:20 +0200
Message-ID	<pJDLc-7RF-21@gated-at.bofh.it> (permalink)
References	<pJ4aJ-2gZ-3@gated-at.bofh.it> <pJ4aJ-2gZ-1@gated-at.bofh.it> <pJqEh-87D-1@gated-at.bofh.it> <pJDrP-7uN-9@gated-at.bofh.it> <pJDLc-7RF-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Guenter, Andrew,

----- On Jul 7, 2015, at 12:07 PM, Andrew Lunn andrew@lunn.ch wrote:

>> Indeed, I intentionally kept it as is, since the 88E6352 datasheet is not
>> really clear about this. I see that the register 0x09 (called
>> GLOBAL_VTU_DATA_8_11 in mv88e6xxx.h) only contains VID priority related bits in
>> 15:12, in my case. As bits 11:0 are reserved, I suspect that the offsets of
>> Member TagP7, Member TagP8 and Member TagP9 are respectively 0, 4 and 8 for
>> you. Can you confirm? If so, I'll make that generic with these values.
> 
> Yes, the pattern continues for up to 11 ports, if you look at the DSDT
> sources from Marvell. The mv88e6131.c driver has one device, the 6095,
> with 11 ports.

Thanks for the details. I make the change and send a v4 asap.

Best,
-v
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v3 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-07-06 04:20 +0200
  [PATCH v3 2/3] net: dsa: add support for switchdev VLAN objects Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-07-06 04:20 +0200
  [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-07-06 04:20 +0200
    Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for  VTU Guenter Roeck <linux@roeck-us.net> - 2015-07-07 18:20 +0200
    Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for  VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-07-07 18:20 +0200
    Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU Andrew Lunn <andrew@lunn.ch> - 2015-07-07 18:20 +0200
  [PATCH v3 3/3] net: dsa: mv88e6xxx: add switchdev VLAN operations Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-07-06 04:20 +0200
  Re: [PATCH v3 0/3] net: dsa: mv88e6xxx: add support for VLAN Table  Unit Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-07-07 18:20 +0200
    Re: [PATCH v3 0/3] net: dsa: mv88e6xxx: add support for VLAN Table  Unit Andrew Lunn <andrew@lunn.ch> - 2015-07-07 18:30 +0200

csiph-web