Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU
Date	Tue, 07 Jul 2015 18:20:02 +0200
Message-ID	<pJDLc-7RF-21@gated-at.bofh.it> (permalink)
References	<pJ4aJ-2gZ-3@gated-at.bofh.it> <pJ4aJ-2gZ-1@gated-at.bofh.it> <pJqEh-87D-1@gated-at.bofh.it> <pJDrP-7uN-9@gated-at.bofh.it> <pJDLc-7RF-23@gated-at.bofh.it>
X-Original-To	Andrew Lunn <andrew@lunn.ch>, Guenter Roeck <linux@roeck-us.net>
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Transfer-Encoding	7bit
X-Mailer	Zimbra 8.6.0_GA_1153 (ZimbraWebClient - FF38 (Linux)/8.6.0_GA_1153)
Thread-Topic	mv88e6xxx: add debugfs interface for VTU
Thread-Index	TRaz8IXLUyjjvKoRXaixtLb1gl+03g==
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	netdev <netdev@vger.kernel.org>, David <davem@davemloft.net>, Scott Feldman <sfeldma@gmail.com>, Jiri Pirko <jiri@resnulli.us>, Florian Fainelli <f.fainelli@gmail.com>, linux-kernel <linux-kernel@vger.kernel.org>, kernel <kernel@savoirfairelinux.com>
X-Original-Date	Tue, 7 Jul 2015 12:19:29 -0400 (EDT)
X-Original-Message-ID	<1021310176.218025.1436285969810.JavaMail.zimbra@savoirfairelinux.com>
X-Original-References	<1436148893-14379-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1436148893-14379-2-git-send-email-vivien.didelot@savoirfairelinux.com> <20150707020818.GB5540@lunn.ch> <1165322565.210276.1436284349938.JavaMail.zimbra@savoirfairelinux.com> <20150707160744.GA13230@lunn.ch>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1178700

Show key headers only | View raw

Hi Guenter, Andrew,

----- On Jul 7, 2015, at 12:07 PM, Andrew Lunn andrew@lunn.ch wrote:

>> Indeed, I intentionally kept it as is, since the 88E6352 datasheet is not
>> really clear about this. I see that the register 0x09 (called
>> GLOBAL_VTU_DATA_8_11 in mv88e6xxx.h) only contains VID priority related bits in
>> 15:12, in my case. As bits 11:0 are reserved, I suspect that the offsets of
>> Member TagP7, Member TagP8 and Member TagP9 are respectively 0, 4 and 8 for
>> you. Can you confirm? If so, I'll make that generic with these values.
> 
> Yes, the pattern continues for up to 11 ports, if you look at the DSDT
> sources from Marvell. The mv88e6131.c driver has one device, the 6095,
> with 11 ports.

Thanks for the details. I make the change and send a v4 asap.

Best,
-v
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v3 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-07-06 04:20 +0200
  [PATCH v3 2/3] net: dsa: add support for switchdev VLAN objects Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-07-06 04:20 +0200
  [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-07-06 04:20 +0200
    Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for  VTU Guenter Roeck <linux@roeck-us.net> - 2015-07-07 18:20 +0200
    Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for  VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-07-07 18:20 +0200
    Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU Andrew Lunn <andrew@lunn.ch> - 2015-07-07 18:20 +0200
  [PATCH v3 3/3] net: dsa: mv88e6xxx: add switchdev VLAN operations Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-07-06 04:20 +0200
  Re: [PATCH v3 0/3] net: dsa: mv88e6xxx: add support for VLAN Table  Unit Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-07-07 18:20 +0200
    Re: [PATCH v3 0/3] net: dsa: mv88e6xxx: add support for VLAN Table  Unit Andrew Lunn <andrew@lunn.ch> - 2015-07-07 18:30 +0200

csiph-web