Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1176881

Re: [PATCH v2 1/6] dax: Add block size note to documentation

Show all headers | View raw

On 07/04/2015 08:03 AM, Christoph Hellwig wrote:
> On Fri, Jul 03, 2015 at 10:40:38AM -0400, Matthew Wilcox wrote:
>> From: Matthew Wilcox <willy@linux.intel.com>
>>
>> For block devices which are small enough, mkfs will default to creating
>> a filesystem with block sizes smaller than page size.
> 
> This seems like an odd note.  At least for XFS and btrfs filesystem size
> don't change block sizes.  ff this is an extN oddity you're probably
> better off documenting it there.
> 

Is why I added to brd:
	/* This is so fdisk will align partitions on 4k, because of
	 * direct_access API needing 4k alignment, returning a PFN
	 * (This is only a problem on very small devices <= 4M,
	 *  otherwise fdisk will align on 1M. Regardless this call
	 *  is harmless)
	 */
	blk_queue_physical_block_size(brd->brd_queue, PAGE_SIZE);

Perhaps add the same to pmem, and/or perhaps make mkfs.extX
also inspect this and not create blocks smaller then physical_block_size?

Thanks
Boaz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/6] dax: Add block size note to documentation Matthew Wilcox <matthew.r.wilcox@intel.com> - 2015-07-03 16:50 +0200
  Re: [PATCH v2 1/6] dax: Add block size note to documentation Boaz Harrosh <openosd@gmail.com> - 2015-07-05 10:50 +0200

csiph-web