Re: [PATCH v2 1/6] dax: Add block size note to documentation

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Boaz Harrosh <openosd@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/6] dax: Add block size note to documentation
Date	Sun, 05 Jul 2015 10:50:01 +0200
Message-ID	<pINMB-Ad-15@gated-at.bofh.it> (permalink)
References	<pIarT-1ha-3@gated-at.bofh.it> <pIarU-1ha-15@gated-at.bofh.it> <pInSa-1ks-3@gated-at.bofh.it>
X-Original-To	Christoph Hellwig <hch@infradead.org>, Matthew Wilcox <matthew.r.wilcox@intel.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=lNYwaqVM8lOvtFdWxEpgtrLXjr1Z8lcsSyYtBiStqew=; b=Dks12MQO57A46mwVHyUuNb+P+b2vXhUDR/NZcwOUQPUFLZu+62OS3r0CL0TgAzUIA/ iQ8H2uJGDPwWa5mt731D3DOmKP/Jd4N4iG4Bx5KkK7lR6MTpCRcJZzNFx6it/LbDwbAL DszTA3IQC3M/L4aRyJN+RkacJlf55NAh7eg1QemU/K9OiUUIJikeB6EyK5czkyUVQpLF yZX3Icmc+HydChJvG9JlTCL0J64Cc5Va/6PefGQf/2XBBSZkNs+FhsLX7a1I2m8K4beJ gOin4/AKVdWbL5TF7dZRoindWPD6dsqDBcIjgmPDg4DXFYFQh+EWvjlY3y+0SOirydQl LP5w==
X-Received	by 10.180.72.179 with SMTP id e19mr82864308wiv.53.1436085833680; Sun, 05 Jul 2015 01:43:53 -0700 (PDT)
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>, Matthew Wilcox <willy@linux.intel.com>
X-Original-Date	Sun, 05 Jul 2015 11:43:51 +0300
X-Original-Message-ID	<5598EE47.1030204@gmail.com>
X-Original-References	<1435934443-17090-1-git-send-email-matthew.r.wilcox@intel.com> <1435934443-17090-2-git-send-email-matthew.r.wilcox@intel.com> <20150704050329.GA22452@infradead.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1176881

Show key headers only | View raw

On 07/04/2015 08:03 AM, Christoph Hellwig wrote:
> On Fri, Jul 03, 2015 at 10:40:38AM -0400, Matthew Wilcox wrote:
>> From: Matthew Wilcox <willy@linux.intel.com>
>>
>> For block devices which are small enough, mkfs will default to creating
>> a filesystem with block sizes smaller than page size.
> 
> This seems like an odd note.  At least for XFS and btrfs filesystem size
> don't change block sizes.  ff this is an extN oddity you're probably
> better off documenting it there.
> 

Is why I added to brd:
	/* This is so fdisk will align partitions on 4k, because of
	 * direct_access API needing 4k alignment, returning a PFN
	 * (This is only a problem on very small devices <= 4M,
	 *  otherwise fdisk will align on 1M. Regardless this call
	 *  is harmless)
	 */
	blk_queue_physical_block_size(brd->brd_queue, PAGE_SIZE);

Perhaps add the same to pmem, and/or perhaps make mkfs.extX
also inspect this and not create blocks smaller then physical_block_size?

Thanks
Boaz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/6] dax: Add block size note to documentation Matthew Wilcox <matthew.r.wilcox@intel.com> - 2015-07-03 16:50 +0200
  Re: [PATCH v2 1/6] dax: Add block size note to documentation Boaz Harrosh <openosd@gmail.com> - 2015-07-05 10:50 +0200

csiph-web