Groups > linux.kernel > #1171947

Re: [PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF
Date	2015-06-25 10:40 +0200
Message-ID	<pFaRs-3s2-3@gated-at.bofh.it> (permalink)
References	<pF3df-zY-3@gated-at.bofh.it> <pF3df-zY-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:

> The ChromeOS EC SPI transport driver has a dependency on OF because it
> uses some OF helpers from the <linux/of.h> header. But there isn't a
> need for an explicit dependency since the header has stub functions if
> CONFIG_OF is not defined.
> 
> Also, MFD_CROS_EC_SPI already depends on MFD_CROS_EC which in turn has
> a dependency on OF so in practice can't be selected without CONFIG_OF.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> 
> ---
> 
>  drivers/mfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied for v4.3, thanks.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 653815950aa2..3f68dd251ce8 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -115,7 +115,7 @@ config MFD_CROS_EC_I2C
>  
>  config MFD_CROS_EC_SPI
>  	tristate "ChromeOS Embedded Controller (SPI)"
> -	depends on MFD_CROS_EC && CROS_EC_PROTO && SPI && OF
> +	depends on MFD_CROS_EC && CROS_EC_PROTO && SPI
>  
>  	---help---
>  	  If you say Y here, you get support for talking to the ChromeOS EC

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF Javier Martinez Canillas <javier.martinez@collabora.co.uk> - 2015-06-25 02:30 +0200
  Re: [PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF Lee Jones <lee.jones@linaro.org> - 2015-06-25 10:40 +0200

csiph-web