Groups > linux.kernel > #1171947

Re: [PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF
Date	Thu, 25 Jun 2015 10:40:02 +0200
Message-ID	<pFaRs-3s2-3@gated-at.bofh.it> (permalink)
References	<pF3df-zY-3@gated-at.bofh.it> <pF3df-zY-9@gated-at.bofh.it>
X-Original-To	Javier Martinez Canillas <javier.martinez@collabora.co.uk>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=cyEJkIgtBNtyQhsnkWATM+LrSSTGNRnlQPBwhBpnQ8I=; b=iBZrkQwHlSvnT+zI1YXhpNAIKrKHD/5KCduoLjKWa5Z1O8tCdqGArUV90AGhHjzY0h m4c50I42PG7jbkauvyEpr2wRMp/40v8p4ewZtg0j4x29TrCpL5idvvka3rCKts8pBZjP NpS+Zeext2vpuZp63SqCJTvD0vS03fq/9dMHPKLg0o2uyugP42q1MDTwQQQYfcBL4JBl tRwbjTIEmqIi/dVn1mp3MZyId34lNI2bKvbEyP1/yG4prDKSXgt28xvg2T7QM3uONmeG FyCtPJh2xcISPG+6najcNtnjXuBkOY4w8+52lF4N5lEvlYIRSy3FI7EdDxIFWXZL093d S7CQ==
X-Gm-Message-State	ALoCoQk0Dmn/116pBg9zUWOKOird4z9rS/ja+ui1ta9+HeyVNcZPCTXmbx+d7180MNl/vE1igOFW
X-Received	by 10.180.211.106 with SMTP id nb10mr3528966wic.33.1435221514164; Thu, 25 Jun 2015 01:38:34 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
Content-Transfer-Encoding	8bit
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
Organization	linux.* mail to news gateway
X-Original-Cc	linux-samsung-soc@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>, Paul Gortmaker <paul.gortmaker@windriver.com>, Gwendal Grignou <gwendal@google.com>, Doug Anderson <dianders@chromium.org>, linux-kernel@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>, Olof Johansson <olof@lixom.net>
X-Original-Date	Thu, 25 Jun 2015 09:38:30 +0100
X-Original-Message-ID	<20150625083830.GU15013@x1>
X-Original-References	<1435191645-6022-1-git-send-email-javier.martinez@collabora.co.uk> <1435191645-6022-4-git-send-email-javier.martinez@collabora.co.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1171947

Show key headers only | View raw

On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:

> The ChromeOS EC SPI transport driver has a dependency on OF because it
> uses some OF helpers from the <linux/of.h> header. But there isn't a
> need for an explicit dependency since the header has stub functions if
> CONFIG_OF is not defined.
> 
> Also, MFD_CROS_EC_SPI already depends on MFD_CROS_EC which in turn has
> a dependency on OF so in practice can't be selected without CONFIG_OF.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> 
> ---
> 
>  drivers/mfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied for v4.3, thanks.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 653815950aa2..3f68dd251ce8 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -115,7 +115,7 @@ config MFD_CROS_EC_I2C
>  
>  config MFD_CROS_EC_SPI
>  	tristate "ChromeOS Embedded Controller (SPI)"
> -	depends on MFD_CROS_EC && CROS_EC_PROTO && SPI && OF
> +	depends on MFD_CROS_EC && CROS_EC_PROTO && SPI
>  
>  	---help---
>  	  If you say Y here, you get support for talking to the ChromeOS EC

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF Javier Martinez Canillas <javier.martinez@collabora.co.uk> - 2015-06-25 02:30 +0200
  Re: [PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF Lee Jones <lee.jones@linaro.org> - 2015-06-25 10:40 +0200

csiph-web