Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA

From	Javier Martinez Canillas <javier@dowhile0.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA
Date	2015-06-25 02:40 +0200
Message-ID	<pF3mV-KX-7@gated-at.bofh.it> (permalink)
References	(4 earlier) <pDINz-875-5@gated-at.bofh.it> <pDIXg-8iq-15@gated-at.bofh.it> <pE4l3-5kw-5@gated-at.bofh.it> <pE4XM-6iS-13@gated-at.bofh.it> <pF2TU-d1-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Paul,

On Thu, Jun 25, 2015 at 2:00 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> [Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA] On 22/06/2015 (Mon 15:59) Herbert Xu wrote:
>
>> On Mon, Jun 22, 2015 at 09:23:36AM +0200, Boris Brezillon wrote:
>> > Hi Herbert,
>> >
>> > On Sun, 21 Jun 2015 16:27:17 +0800
>> > Herbert Xu <herbert@gondor.apana.org.au> wrote:
>> >
>> > > On Sun, Jun 21, 2015 at 10:24:18AM +0200, Boris Brezillon wrote:
>> > > >
>> > > > Indeed. Here is a patch fixing that.
>> > >
>> > > I think you should just kill COMPILE_TEST instead of adding ARM.
>> >
>> > The following patch is killing the COMPILE_TEST dependency.
>>
>> Patch applied.
>
> Just a heads up, this driver is still killing a couple of linux-next
> builds today and for the past few days.
>
> drivers/crypto/mv_cesa.c:1037:2: error: implicit declaration of function
> 'of_get_named_gen_pool' [-Werror=implicit-function-declaration]
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12448851/
> http://kisskb.ellerman.id.au/kisskb/buildresult/12448776/
>
> Missing dependency on CONFIG_OF_<blah> presumably.
>

I haven't looked at the series but <linux/genalloc.h> has a stub
of_get_named_gen_pool() function if CONFIG_OF is not enabled [0].

So it seems that the problem is rather that the header is not being
included in some file.

> Paul.
> --
>

Best regards,
Javier

[0]: http://lxr.free-electrons.com/source/include/linux/genalloc.h#L131
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-06-25 02:10 +0200
  Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA Javier Martinez Canillas <javier@dowhile0.org> - 2015-06-25 02:40 +0200
    [PATCH] crypto: mv_cesa - fix up for of_get_named_gen_pool() rename Simon Guinot <simon.guinot@sequanux.org> - 2015-06-25 10:50 +0200

csiph-web