Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA

Path	csiph.com!aioe.org!news.mixmin.net!goblin1!goblin2!goblin.stu.neva.ru!weretis.net!feeder4.news.weretis.net!feeder1.news.weretis.net!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod
From	Javier Martinez Canillas <javier@dowhile0.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA
Date	Thu, 25 Jun 2015 02:40:01 +0200
Message-ID	<pF3mV-KX-7@gated-at.bofh.it> (permalink)
References	<pCImB-1Ew-3@gated-at.bofh.it> <pD5sR-1yD-5@gated-at.bofh.it> <pDxIt-B1-5@gated-at.bofh.it> <pDB9o-5Fg-3@gated-at.bofh.it> <pDINz-875-5@gated-at.bofh.it> <pDIXg-8iq-15@gated-at.bofh.it> <pE4l3-5kw-5@gated-at.bofh.it> <pE4XM-6iS-13@gated-at.bofh.it> <pF2TU-d1-15@gated-at.bofh.it>
X-Original-To	Paul Gortmaker <paul.gortmaker@windriver.com>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=xGdMM9Ve9Ec/147GXnUIPivYUTG/iRy4fwyx4fGt1tU=; b=kR6PtQQSZmjUWveFgSPJrIMDzA8Orq0KGgXnRrVaSCTY9vkYVr14kvsK2lg6yW77bK Nh6wBRKXzS8y6DMOZYcsaVUZXzA/zbQfAg7eSm4QHAAurRTPAkdVfSB1nmxJ1JACl2+t 72CQps9NXvB93dsNPVL30tOh3E5EaJKHro5Alx3/HdeJHgMPbnurX0OhYBrFhbszBOKS O/cg1NKOcCYYlVPynZ/+cstNGODwlEVycSCQle52onmwGZY2rjIfxZbpdEUMS85Df8nC 8i80y59mZ9PwoIimDqXXP2phJU3s0T9NiaUIuFh8l/AUWfTttOPQEar32a1909Ccuzuy U5mw==
X-Gm-Message-State	ALoCoQlTtETxaGCwCtM9QEpezzJS4EwCLeBbWAgfCjtYxL2JgARl4qkwlf20/hM6Y9OVVzY5fUFU
MIME-Version	1.0
X-Received	by 10.170.110.82 with SMTP id c79mr52330942ykb.113.1435192423328; Wed, 24 Jun 2015 17:33:43 -0700 (PDT)
X-Originating-IP	[37.11.0.18]
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	53
Organization	linux.* mail to news gateway
X-Original-Cc	Herbert Xu <herbert@gondor.apana.org.au>, Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>, Nadav Haklai <nadavh@marvell.com>, Mark Rutland <mark.rutland@arm.com>, Boris Brezillon <boris.brezillon@free-electrons.com>, Russell King - ARM Linux <linux@arm.linux.org.uk>, Tawfik Bayouk <tawfik@marvell.com>, Eran Ben-Avi <benavi@marvell.com>, Jason Gunthorpe <jgunthorpe@obsidianresearch.com>, "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Jason Cooper <jason@lakedaemon.net>, Pawel Moll <pawel.moll@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Arnaud Ebalard <arno@natisbad.org>, Rob Herring <robh+dt@kernel.org>, Gregory CLEMENT <gregory.clement@free-electrons.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Thomas Petazzoni <thomas.petazzoni@free-electrons.com>, LKML <linux-kernel@vger.kernel.org>, linux-crypto@vger.kernel.org, Kumar Gala <galak@codeaurora.org>, Imre Kaloz <kaloz@openwrt.org>, "David S. Miller" <davem@davemloft.net>
X-Original-Date	Thu, 25 Jun 2015 02:33:43 +0200
X-Original-Message-ID	<CABxcv=m4juAMHaMYSB+8O8cEX+YZCJ0cArS2wN-YGpTBgWe-CA@mail.gmail.com>
X-Original-References	<1434635190-27733-1-git-send-email-boris.brezillon@free-electrons.com> <20150619142444.GA15234@gondor.apana.org.au> <CAP=VYLqQynCNRTpm4JnOxeO6DH_739fO2QNcDMxaXqCKCHiTtQ@mail.gmail.com> <CAP=VYLpSrTvXRovWo4G7AXWv1OKFQRpQR255hS5z+=h4+XOLhg@mail.gmail.com> <20150621102418.2ea74910@bbrezillon> <20150621082717.GA29128@gondor.apana.org.au> <20150622092336.5949e258@bbrezillon> <20150622075910.GA7659@gondor.apana.org.au> <20150625000037.GK31584@windriver.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1171774

Show key headers only | View raw

Hello Paul,

On Thu, Jun 25, 2015 at 2:00 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> [Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA] On 22/06/2015 (Mon 15:59) Herbert Xu wrote:
>
>> On Mon, Jun 22, 2015 at 09:23:36AM +0200, Boris Brezillon wrote:
>> > Hi Herbert,
>> >
>> > On Sun, 21 Jun 2015 16:27:17 +0800
>> > Herbert Xu <herbert@gondor.apana.org.au> wrote:
>> >
>> > > On Sun, Jun 21, 2015 at 10:24:18AM +0200, Boris Brezillon wrote:
>> > > >
>> > > > Indeed. Here is a patch fixing that.
>> > >
>> > > I think you should just kill COMPILE_TEST instead of adding ARM.
>> >
>> > The following patch is killing the COMPILE_TEST dependency.
>>
>> Patch applied.
>
> Just a heads up, this driver is still killing a couple of linux-next
> builds today and for the past few days.
>
> drivers/crypto/mv_cesa.c:1037:2: error: implicit declaration of function
> 'of_get_named_gen_pool' [-Werror=implicit-function-declaration]
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12448851/
> http://kisskb.ellerman.id.au/kisskb/buildresult/12448776/
>
> Missing dependency on CONFIG_OF_<blah> presumably.
>

I haven't looked at the series but <linux/genalloc.h> has a stub
of_get_named_gen_pool() function if CONFIG_OF is not enabled [0].

So it seems that the problem is rather that the header is not being
included in some file.

> Paul.
> --
>

Best regards,
Javier

[0]: http://lxr.free-electrons.com/source/include/linux/genalloc.h#L131
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-06-25 02:10 +0200
  Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA Javier Martinez Canillas <javier@dowhile0.org> - 2015-06-25 02:40 +0200
    [PATCH] crypto: mv_cesa - fix up for of_get_named_gen_pool() rename Simon Guinot <simon.guinot@sequanux.org> - 2015-06-25 10:50 +0200

csiph-web